Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary code from dask-cudf _Frame #12001

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Remove unnecessary code from dask-cudf _Frame #12001

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74dc944
remove redundant code from dask_cudf _Frame init
rjzamora Oct 26, 2022
703b2d2
reformat
rjzamora Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 2 additions & 30 deletions python/dask_cudf/dask_cudf/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
from dask.base import normalize_token, tokenize
from dask.dataframe.core import (
Scalar,
finalize,
handle_out,
make_meta as dask_make_meta,
map_partitions,
Expand Down Expand Up @@ -55,35 +54,8 @@ class _Frame(dd.core._Frame, OperatorMethodMixin):
Values along which we partition our blocks on the index
"""

__dask_scheduler__ = staticmethod(dask.get)

def __dask_postcompute__(self):
return finalize, ()

def __dask_postpersist__(self):
return type(self), (self._name, self._meta, self.divisions)

@_dask_cudf_nvtx_annotate
def __init__(self, dsk, name, meta, divisions):
if not isinstance(dsk, HighLevelGraph):
dsk = HighLevelGraph.from_collections(name, dsk, dependencies=[])
self.dask = dsk
self._name = name
meta = dask_make_meta(meta)
if not isinstance(meta, self._partition_type):
raise TypeError(
f"Expected meta to specify type "
f"{self._partition_type.__name__}, got type "
f"{type(meta).__name__}"
)
self._meta = meta
self.divisions = tuple(divisions)

def __getstate__(self):
return (self.dask, self._name, self._meta, self.divisions)

def __setstate__(self, state):
self.dask, self._name, self._meta, self.divisions = state
def _is_partition_type(self, meta):
return isinstance(meta, self._partition_type)

def __repr__(self):
s = "<dask_cudf.%s | %d tasks | %d npartitions>"
Expand Down