-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to DISABLE_DEPRECATION_WARNINGS to match other RAPIDS projects #11989
Switch to DISABLE_DEPRECATION_WARNINGS to match other RAPIDS projects #11989
Conversation
Thanks for following up, I was going to start looking to make sure we were consistent too. |
@gpucibot merge |
@robertmaynard I updated the copyright, that should hopefully be enough to get through tests. |
@gpucibot merge |
Codecov ReportBase: 87.40% // Head: 88.15% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #11989 +/- ##
================================================
+ Coverage 87.40% 88.15% +0.74%
================================================
Files 133 133
Lines 21833 21995 +162
================================================
+ Hits 19084 19389 +305
+ Misses 2749 2606 -143
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@gpucibot merge |
Description
Use the term
DISABLE_DEPRECATION_WARNINGS
so that we match other RAPIDS projects rapidsai/cuml#4946 plus the plural tense in general makes more sense.Checklist