Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to DISABLE_DEPRECATION_WARNINGS to match other RAPIDS projects #11989

Merged

Conversation

robertmaynard
Copy link
Contributor

Description

Use the term DISABLE_DEPRECATION_WARNINGS so that we match other RAPIDS projects rapidsai/cuml#4946 plus the plural tense in general makes more sense.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Oct 25, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner October 25, 2022 17:13
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Oct 25, 2022
@robertmaynard robertmaynard requested a review from vyasr October 25, 2022 17:13
@vyasr
Copy link
Contributor

vyasr commented Oct 25, 2022

Thanks for following up, I was going to start looking to make sure we were consistent too.

@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@vyasr
Copy link
Contributor

vyasr commented Oct 25, 2022

@robertmaynard I updated the copyright, that should hopefully be enough to get through tests.

@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 87.40% // Head: 88.15% // Increases project coverage by +0.74% 🎉

Coverage data is based on head (4bf083d) compared to base (f72c4ce).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11989      +/-   ##
================================================
+ Coverage         87.40%   88.15%   +0.74%     
================================================
  Files               133      133              
  Lines             21833    21995     +162     
================================================
+ Hits              19084    19389     +305     
+ Misses             2749     2606     -143     
Impacted Files Coverage Δ
python/strings_udf/strings_udf/__init__.py 86.27% <0.00%> (-10.61%) ⬇️
python/cudf/cudf/io/text.py 91.66% <0.00%> (-8.34%) ⬇️
python/cudf/cudf/core/_base_index.py 82.20% <0.00%> (-3.35%) ⬇️
python/strings_udf/strings_udf/_typing.py 94.73% <0.00%> (-1.06%) ⬇️
python/cudf/cudf/testing/dataset_generator.py 72.83% <0.00%> (-0.42%) ⬇️
python/dask_cudf/dask_cudf/backends.py 84.90% <0.00%> (-0.37%) ⬇️
python/dask_cudf/dask_cudf/core.py 73.92% <0.00%> (-0.21%) ⬇️
python/cudf/cudf/io/orc.py 92.94% <0.00%> (-0.09%) ⬇️
python/cudf/cudf/__init__.py 90.69% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 79.47% <0.00%> (ø)
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vyasr
Copy link
Contributor

vyasr commented Oct 25, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b7d0115 into rapidsai:branch-22.12 Oct 25, 2022
@robertmaynard robertmaynard deleted the fix/deprecation_warning_arg branch October 26, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants