Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pool memory resource to libcudf basic example #11966

Merged
merged 7 commits into from
Oct 25, 2022

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Oct 21, 2022

Description

Adds the pool memory resource to the libcudf basic example.
Also adds README.md to the strings example and makes some minor fixes to the documentation.

Closes #11870

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 21, 2022
@davidwendt davidwendt self-assigned this Oct 21, 2022
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 88.11% // Head: 88.14% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (97b706c) compared to base (5c2150e).
Patch has no changes to coverable lines.

❗ Current head 97b706c differs from pull request most recent head cfd3c0e. Consider uploading reports for the commit cfd3c0e to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11966      +/-   ##
================================================
+ Coverage         88.11%   88.14%   +0.02%     
================================================
  Files               133      133              
  Lines             21982    21982              
================================================
+ Hits              19369    19375       +6     
+ Misses             2613     2607       -6     
Impacted Files Coverage Δ
python/cudf/cudf/core/dataframe.py 93.77% <0.00%> (+0.04%) ⬆️
python/cudf/cudf/core/column/string.py 88.65% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.51% <0.00%> (+0.20%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 93.75% <0.00%> (+0.96%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 24, 2022
@davidwendt davidwendt marked this pull request as ready for review October 24, 2022 14:13
@davidwendt davidwendt requested a review from a team as a code owner October 24, 2022 14:13
@vuule vuule added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Oct 25, 2022
@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit dc5924c into rapidsai:branch-22.12 Oct 25, 2022
@davidwendt davidwendt deleted the example-memory-resource branch October 25, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] The libcudf example should show how to use a memory resource
4 participants