-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some libcudf calls to cudf::detail::gather #11963
Fix some libcudf calls to cudf::detail::gather #11963
Conversation
Codecov ReportBase: 87.40% // Head: 88.14% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #11963 +/- ##
================================================
+ Coverage 87.40% 88.14% +0.73%
================================================
Files 133 133
Lines 21833 21982 +149
================================================
+ Hits 19084 19375 +291
+ Misses 2749 2607 -142
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great find! 👍
@gpucibot merge |
Description
Fixes a couple source files that were calling gather by type-dispatching directly to the internal
column_gatherer
functor instead of using thecudf::detail::gather
function(s). This simplifies the code and improves maintenance. For example, extra code to resolve the null-mask is eliminated since the appropriatecudf::detail::gather
call does this automatically.No function has changed, just code cleanup.
Checklist