Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some libcudf calls to cudf::detail::gather #11963

Merged

Conversation

davidwendt
Copy link
Contributor

Description

Fixes a couple source files that were calling gather by type-dispatching directly to the internal column_gatherer functor instead of using the cudf::detail::gather function(s). This simplifies the code and improves maintenance. For example, extra code to resolve the null-mask is eliminated since the appropriate cudf::detail::gather call does this automatically.
No function has changed, just code cleanup.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. tech debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 20, 2022
@davidwendt davidwendt self-assigned this Oct 20, 2022
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 87.40% // Head: 88.14% // Increases project coverage by +0.73% 🎉

Coverage data is based on head (9e3e1c4) compared to base (f72c4ce).
Patch coverage: 90.03% of modified lines in pull request are covered.

❗ Current head 9e3e1c4 differs from pull request most recent head 7a82bf0. Consider uploading reports for the commit 7a82bf0 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11963      +/-   ##
================================================
+ Coverage         87.40%   88.14%   +0.73%     
================================================
  Files               133      133              
  Lines             21833    21982     +149     
================================================
+ Hits              19084    19375     +291     
+ Misses             2749     2607     -142     
Impacted Files Coverage Δ
python/cudf/cudf/core/dataframe.py 93.77% <ø> (ø)
python/cudf/cudf/core/frame.py 93.68% <ø> (ø)
python/cudf/cudf/core/indexed_frame.py 92.03% <ø> (ø)
python/cudf/cudf/core/udf/__init__.py 97.05% <ø> (+47.05%) ⬆️
python/cudf/cudf/io/orc.py 92.94% <ø> (-0.09%) ⬇️
python/cudf/cudf/testing/dataset_generator.py 72.83% <ø> (-0.42%) ⬇️
...thon/dask_cudf/dask_cudf/tests/test_distributed.py 18.86% <ø> (+4.94%) ⬆️
python/cudf/cudf/core/_base_index.py 82.20% <43.75%> (-3.35%) ⬇️
python/cudf/cudf/io/text.py 91.66% <66.66%> (-8.34%) ⬇️
python/strings_udf/strings_udf/__init__.py 84.31% <76.00%> (-12.57%) ⬇️
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 24, 2022
@davidwendt davidwendt marked this pull request as ready for review October 24, 2022 13:50
@davidwendt davidwendt requested a review from a team as a code owner October 24, 2022 13:50
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find! 👍

@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit fac35b4 into rapidsai:branch-22.12 Oct 26, 2022
@davidwendt davidwendt deleted the fix-detail-gather-calls branch October 26, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants