Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning for set_allocator. #11958

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Oct 20, 2022

Description

Resolves #11097.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change deprecation labels Oct 20, 2022
@vyasr vyasr requested a review from a team as a code owner October 20, 2022 20:32
@vyasr vyasr self-assigned this Oct 20, 2022
@vyasr vyasr requested review from wence- and charlesbluca October 20, 2022 20:32
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 87.40% // Head: 88.14% // Increases project coverage by +0.73% 🎉

Coverage data is based on head (15ac947) compared to base (f72c4ce).
Patch coverage: 89.73% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11958      +/-   ##
================================================
+ Coverage         87.40%   88.14%   +0.73%     
================================================
  Files               133      133              
  Lines             21833    21984     +151     
================================================
+ Hits              19084    19377     +293     
+ Misses             2749     2607     -142     
Impacted Files Coverage Δ
python/cudf/cudf/core/dataframe.py 93.77% <ø> (ø)
python/cudf/cudf/core/indexed_frame.py 92.03% <ø> (ø)
python/cudf/cudf/core/udf/__init__.py 97.05% <ø> (+47.05%) ⬆️
python/cudf/cudf/io/orc.py 92.94% <ø> (-0.09%) ⬇️
python/cudf/cudf/testing/dataset_generator.py 72.83% <ø> (-0.42%) ⬇️
...thon/dask_cudf/dask_cudf/tests/test_distributed.py 18.86% <ø> (+4.94%) ⬆️
python/cudf/cudf/core/_base_index.py 82.20% <43.75%> (-3.35%) ⬇️
python/cudf/cudf/utils/utils.py 89.91% <50.00%> (-0.69%) ⬇️
python/cudf/cudf/io/text.py 91.66% <66.66%> (-8.34%) ⬇️
python/strings_udf/strings_udf/__init__.py 86.27% <76.00%> (-10.61%) ⬇️
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vyasr vyasr requested a review from shwina October 25, 2022 22:38
@shwina
Copy link
Contributor

shwina commented Oct 28, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c915523 into rapidsai:branch-22.12 Oct 28, 2022
@vyasr vyasr deleted the deprecation/set_allocator branch December 1, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Add set_allocator to cuDF Python documentation (or deprecate in favor of rmm.reinitialize)
3 participants