Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lists and structs gtests coded in namespace cudf::test #11956

Merged

Conversation

davidwendt
Copy link
Contributor

Description

Fixes structs and lists gtests source files coded in namespace cudf::test
These are the only 2 problem files for this in cpp/tests/structs and cpp/tests/lists and so will make those two directories complete.
No function or test has changed just the source code reworked per namespaces.

Reference #11734

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 20, 2022
@davidwendt davidwendt requested a review from a team as a code owner October 20, 2022 19:27
@davidwendt davidwendt self-assigned this Oct 20, 2022
@davidwendt davidwendt requested review from elstehle and vuule October 20, 2022 19:27
Copy link
Contributor

@vuule vuule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 88.11% // Head: 88.14% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (ba5abdd) compared to base (5c2150e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11956      +/-   ##
================================================
+ Coverage         88.11%   88.14%   +0.03%     
================================================
  Files               133      133              
  Lines             21982    21982              
================================================
+ Hits              19369    19376       +7     
+ Misses             2613     2606       -7     
Impacted Files Coverage Δ
python/cudf/cudf/core/dataframe.py 93.77% <0.00%> (+0.04%) ⬆️
python/cudf/cudf/core/column/string.py 88.65% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.51% <0.00%> (+0.20%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 93.75% <0.00%> (+0.96%) ⬆️
python/strings_udf/strings_udf/__init__.py 86.27% <0.00%> (+1.96%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidwendt
Copy link
Contributor Author

rerun tests

@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4c0f2fd into rapidsai:branch-22.12 Oct 24, 2022
@davidwendt davidwendt deleted the fix-gtests-ns-lists-structs branch October 24, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants