Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full page indexes to Parquet writer benchmarks #11955

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

etseidl
Copy link
Contributor

@etseidl etseidl commented Oct 20, 2022

Description

Adds statistics_freq::STATISTICS_COLUMN to list of parquet writer options to benchmark. This should have been included in #11302.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@etseidl etseidl requested a review from a team as a code owner October 20, 2022 19:21
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Oct 20, 2022
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 87.40% // Head: 86.89% // Decreases project coverage by -0.51% ⚠️

Coverage data is based on head (07b86de) compared to base (f72c4ce).
Patch coverage: 90.03% of modified lines in pull request are covered.

❗ Current head 07b86de differs from pull request most recent head 84b8bdc. Consider uploading reports for the commit 84b8bdc to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11955      +/-   ##
================================================
- Coverage         87.40%   86.89%   -0.52%     
================================================
  Files               133      133              
  Lines             21833    21982     +149     
================================================
+ Hits              19084    19101      +17     
- Misses             2749     2881     +132     
Impacted Files Coverage Δ
python/cudf/cudf/core/dataframe.py 93.73% <ø> (-0.05%) ⬇️
python/cudf/cudf/core/indexed_frame.py 92.03% <ø> (ø)
python/cudf/cudf/core/udf/__init__.py 50.00% <ø> (ø)
python/cudf/cudf/io/orc.py 92.94% <ø> (-0.09%) ⬇️
python/cudf/cudf/testing/dataset_generator.py 72.83% <ø> (-0.42%) ⬇️
...thon/dask_cudf/dask_cudf/tests/test_distributed.py 18.86% <ø> (+4.94%) ⬆️
python/cudf/cudf/core/_base_index.py 82.20% <43.75%> (-3.35%) ⬇️
python/cudf/cudf/io/text.py 91.66% <66.66%> (-8.34%) ⬇️
python/strings_udf/strings_udf/__init__.py 84.31% <76.00%> (-12.57%) ⬇️
python/dask_cudf/dask_cudf/backends.py 84.90% <82.92%> (-0.37%) ⬇️
... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vuule vuule added cuIO cuIO issue non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Nov 2, 2022
@vuule
Copy link
Contributor

vuule commented Nov 2, 2022

@gpucibot merge

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

@rapids-bot rapids-bot bot merged commit 856ac3f into rapidsai:branch-22.12 Nov 2, 2022
@etseidl etseidl deleted the feature/stats_benchmark branch November 3, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants