Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gather-based strings factory in cudf::strings::strip #11954

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

davidwendt
Copy link
Contributor

Description

Simplifies the cudf::strings::strip function to use the cudf::make_strings_column that accepts an iterator of pairs. This factory has a highly tuned gather implementation for building a strings column from an vector (iterator) of strings in device memory.
This was inspired by the review and work in #11946. This also gives a small improvement in the performance of small columns of large strings and even more improvement in large columns of large-ish strings for strip.
No function has changed just the internal implementation has been simplified.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 20, 2022
@davidwendt davidwendt self-assigned this Oct 20, 2022
@davidwendt davidwendt requested a review from a team as a code owner October 20, 2022 19:04
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 88.09% // Head: 88.14% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (4e0a5a6) compared to base (6ca2ceb).
Patch coverage: 92.63% of modified lines in pull request are covered.

❗ Current head 4e0a5a6 differs from pull request most recent head e8c2bdc. Consider uploading reports for the commit e8c2bdc to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11954      +/-   ##
================================================
+ Coverage         88.09%   88.14%   +0.04%     
================================================
  Files               133      133              
  Lines             21905    21982      +77     
================================================
+ Hits              19298    19375      +77     
  Misses             2607     2607              
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/backends.py 84.90% <82.92%> (-0.37%) ⬇️
python/cudf/cudf/core/column/column.py 88.46% <100.00%> (+0.04%) ⬆️
python/dask_cudf/dask_cudf/core.py 73.92% <100.00%> (-0.21%) ⬇️
python/dask_cudf/dask_cudf/io/tests/test_csv.py 100.00% <100.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_json.py 100.00% <100.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_orc.py 100.00% <100.00%> (ø)
...ython/dask_cudf/dask_cudf/io/tests/test_parquet.py 100.00% <100.00%> (ø)
python/dask_cudf/dask_cudf/tests/test_core.py 95.37% <100.00%> (+0.09%) ⬆️
python/cudf/cudf/core/dataframe.py 93.77% <0.00%> (+0.04%) ⬆️
python/cudf/cudf/core/column/string.py 88.65% <0.00%> (+0.12%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@upsj upsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one question

@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c806b10 into rapidsai:branch-22.12 Oct 24, 2022
@davidwendt davidwendt deleted the faster-strip branch October 24, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants