Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename libcudf++ to libcudf. #11953

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Rename libcudf++ to libcudf. #11953

merged 2 commits into from
Oct 20, 2022

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Oct 20, 2022

Description

For consistency across our documentation, this PR renames libcudf++ to libcudf.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice added doc Documentation non-breaking Non-breaking change labels Oct 20, 2022
@bdice bdice self-assigned this Oct 20, 2022
@bdice bdice requested review from a team as code owners October 20, 2022 18:57
@bdice bdice requested a review from vyasr October 20, 2022 18:57
@bdice bdice requested review from isVoid and upsj October 20, 2022 18:57
@github-actions github-actions bot added Python Affects Python cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Oct 20, 2022
vyasr
vyasr approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I committed one additional change to the line referencing the original libcudf++ presentation. If you think it's more accurate to continue calling that particular instance libcudf++ feel free to revert that change, making the change was the easiest way to point it out.

ttnghia
ttnghia approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@ttnghia ttnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change 😆

jrhemstad
jrhemstad reviewed Oct 20, 2022
View reviewed changes
cpp/doxygen/developer_guide/DEVELOPER_GUIDE.md
@@ -176,7 +176,7 @@ Resource ownership is an essential concept in libcudf. In short, an "owning" obj
resource (such as device memory). It acquires that resource during construction and releases the
resource in destruction ([RAII](https://en.cppreference.com/w/cpp/language/raii)). A "non-owning"
object does not own resources. Any class in libcudf with the `*_view` suffix is non-owning. For more
detail see the [`libcudf++` presentation.](https://docs.google.com/presentation/d/1zKzAtc1AWFKfMhiUlV5yRZxSiPLwsObxMlWRWz_f5hA/edit?usp=sharing)
detail see the [`libcudf` presentation.](https://docs.google.com/presentation/d/1zKzAtc1AWFKfMhiUlV5yRZxSiPLwsObxMlWRWz_f5hA/edit?usp=sharing)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair, this one is the only one that could still stay as libcudf++. More importantly, these slides should probably be somewhere other than my Google Drive... or just remove the link all together. The content within this guide should supersede anything in those slides by this point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m going to leave it as-is. The presentation is titled libcudf++ but it’s about libcudf and I don’t want readers to be confused about the proper name of the library.

@codecov
Copy link

codecov bot commented Oct 20, 2022 •
edited
Loading

Codecov Report

Base: 87.40% // Head: 88.14% // Increases project coverage by +0.73% 🎉

Coverage data is based on head (b79e357) compared to base (f72c4ce).
Patch coverage: 90.03% of modified lines in pull request are covered.

❗ Current head b79e357 differs from pull request most recent head 2406ba3. Consider uploading reports for the commit 2406ba3 to get more accurate results

Additional details and impacted files 
@@               Coverage Diff                @@
##           branch-22.12   #11953      +/-   ##
================================================
+ Coverage         87.40%   88.14%   +0.73%     
================================================
  Files               133      133              
  Lines             21833    21982     +149     
================================================
+ Hits              19084    19376     +292     
+ Misses             2749     2606     -143
Impacted Files Coverage Δ
python/cudf/cudf/core/dataframe.py 93.77% <ø> (ø)
python/cudf/cudf/core/frame.py 93.68% <ø> (ø)
python/cudf/cudf/core/indexed_frame.py 92.03% <ø> (ø)
python/cudf/cudf/core/udf/__init__.py 97.05% <ø> (+47.05%) ⬆️
python/cudf/cudf/io/orc.py 92.94% <ø> (-0.09%) ⬇️
python/cudf/cudf/testing/dataset_generator.py 72.83% <ø> (-0.42%) ⬇️
...thon/dask_cudf/dask_cudf/tests/test_distributed.py 18.86% <ø> (+4.94%) ⬆️
python/cudf/cudf/core/_base_index.py 82.20% <43.75%> (-3.35%) ⬇️
python/cudf/cudf/io/text.py 91.66% <66.66%> (-8.34%) ⬇️
python/strings_udf/strings_udf/__init__.py 86.27% <76.00%> (-10.61%) ⬇️
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdice
Copy link
Contributor Author

bdice commented Oct 20, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5803015 into rapidsai:branch-22.12 Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhemstad jrhemstad jrhemstad left review comments

@davidwendt davidwendt davidwendt approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@ttnghia ttnghia ttnghia approved these changes

@vyasr vyasr vyasr approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@upsj upsj Awaiting requested review from upsj upsj is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@bdice bdice

Labels
doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bdice @vyasr @ttnghia @galipremsagar @jrhemstad @davidwendt