Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add .str.find_multiple API #11928

Merged
merged 9 commits into from
Oct 18, 2022
Merged

[REVIEW] Add .str.find_multiple API #11928

merged 9 commits into from
Oct 18, 2022

Conversation

galipremsagar
Copy link
Contributor

Description

Resolves: #10126

This PR adds .str.find_multiple API.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 14, 2022
@galipremsagar galipremsagar requested a review from a team as a code owner October 14, 2022 21:31
@galipremsagar galipremsagar self-assigned this Oct 14, 2022
galipremsagar
galipremsagar commented Oct 14, 2022
View reviewed changes
python/cudf/cudf/core/column/string.py
f"got: {type(patterns)}"
)

return cudf.Series(
Copy link
Contributor Author

@galipremsagar galipremsagar Oct 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note: Looks like this is one outlier where we might need ListColumn support in cudf.Index but I don't see any practical use post the result is returned as an Index, hence I'm just returning a cudf.Series for both Series & Index type of inputs.

@codecov
Copy link

codecov bot commented Oct 14, 2022 •
edited
Loading

Codecov Report

Base: 87.40% // Head: 88.13% // Increases project coverage by +0.72% 🎉

Coverage data is based on head (ed95679) compared to base (f72c4ce).
Patch coverage: 88.48% of modified lines in pull request are covered.

Additional details and impacted files 
@@               Coverage Diff                @@
##           branch-22.12   #11928      +/-   ##
================================================
+ Coverage         87.40%   88.13%   +0.72%     
================================================
  Files               133      133              
  Lines             21833    21905      +72     
================================================
+ Hits              19084    19305     +221     
+ Misses             2749     2600     -149
Impacted Files Coverage Δ
python/cudf/cudf/core/udf/__init__.py 97.05% <ø> (+47.05%) ⬆️
python/cudf/cudf/io/orc.py 92.94% <ø> (-0.09%) ⬇️
...thon/dask_cudf/dask_cudf/tests/test_distributed.py 18.86% <ø> (+4.94%) ⬆️
python/cudf/cudf/core/_base_index.py 82.20% <43.75%> (-3.35%) ⬇️
python/cudf/cudf/io/text.py 91.66% <66.66%> (-8.34%) ⬇️
python/strings_udf/strings_udf/__init__.py 86.27% <76.00%> (-10.61%) ⬇️
python/cudf/cudf/core/index.py 92.96% <95.71%> (+0.33%) ⬆️
python/cudf/cudf/__init__.py 90.69% <100.00%> (ø)
python/cudf/cudf/_lib/strings/__init__.py 100.00% <100.00%> (ø)
python/cudf/cudf/core/column/categorical.py 89.34% <100.00%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Oct 17, 2022
bdice
bdice requested changes Oct 17, 2022
View reviewed changes
python/cudf/cudf/core/column/string.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/column/string.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/column/string.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_string.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_string.py Show resolved Hide resolved
@galipremsagar galipremsagar requested a review from bdice October 17, 2022 23:10
@galipremsagar galipremsagar removed the 5 - Ready to Merge Testing and reviews complete, ready to merge label Oct 17, 2022
bdice
bdice approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment on test coverage, otherwise LGTM.

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Oct 18, 2022
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a926c52 into rapidsai:branch-22.12 Oct 18, 2022
@shwina shwina mentioned this pull request Nov 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt left review comments

@mroeschke mroeschke mroeschke approved these changes

@bdice bdice bdice approved these changes

@shwina shwina Awaiting requested review from shwina shwina is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Enable .str.find_multiple public API
4 participants
@galipremsagar @bdice @mroeschke @davidwendt