Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local offset handling in bgzip reader #11918

Merged
merged 3 commits into from
Oct 14, 2022

Conversation

upsj
Copy link
Contributor

@upsj upsj commented Oct 14, 2022

Description

We accidentally checked the local offset against the compressed, not the uncompressed size. The new test failed prior to fixing the behavior.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@upsj upsj added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. cuIO cuIO issue non-breaking Non-breaking change labels Oct 14, 2022
@upsj upsj added this to the Genomics read_text support milestone Oct 14, 2022
@upsj upsj self-assigned this Oct 14, 2022
@upsj upsj requested a review from a team as a code owner October 14, 2022 03:38
cpp/tests/io/text/data_chunk_source_test.cpp Outdated Show resolved Hide resolved
cpp/tests/io/text/data_chunk_source_test.cpp Outdated Show resolved Hide resolved
cpp/tests/io/text/data_chunk_source_test.cpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 87.40% // Head: 88.11% // Increases project coverage by +0.70% 🎉

Coverage data is based on head (f2019c9) compared to base (f72c4ce).
Patch coverage: 86.61% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11918      +/-   ##
================================================
+ Coverage         87.40%   88.11%   +0.70%     
================================================
  Files               133      133              
  Lines             21833    21881      +48     
================================================
+ Hits              19084    19281     +197     
+ Misses             2749     2600     -149     
Impacted Files Coverage Δ
python/cudf/cudf/core/udf/__init__.py 97.05% <ø> (+47.05%) ⬆️
python/cudf/cudf/io/orc.py 92.94% <ø> (-0.09%) ⬇️
...thon/dask_cudf/dask_cudf/tests/test_distributed.py 18.86% <ø> (+4.94%) ⬆️
python/cudf/cudf/core/_base_index.py 82.20% <43.75%> (-3.35%) ⬇️
python/cudf/cudf/io/text.py 91.66% <66.66%> (-8.34%) ⬇️
python/strings_udf/strings_udf/__init__.py 86.27% <76.00%> (-10.61%) ⬇️
python/cudf/cudf/core/index.py 92.91% <95.16%> (+0.28%) ⬆️
python/cudf/cudf/__init__.py 90.69% <100.00%> (ø)
python/cudf/cudf/core/column/categorical.py 89.34% <100.00%> (ø)
python/cudf/cudf/core/groupby/groupby.py 91.51% <100.00%> (+0.29%) ⬆️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much cleaner. Thanks @upsj for the iterations and @karthikeyann / @davidwendt for the garbage-generating suggestions. 🗑️

@upsj
Copy link
Contributor Author

upsj commented Oct 14, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8a31e26 into rapidsai:branch-22.12 Oct 14, 2022
@upsj upsj added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants