-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor pad/zfill functions for reuse with strings udf #11914
Refactor pad/zfill functions for reuse with strings udf #11914
Conversation
Codecov ReportBase: 87.40% // Head: 88.12% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #11914 +/- ##
================================================
+ Coverage 87.40% 88.12% +0.71%
================================================
Files 133 133
Lines 21833 21905 +72
================================================
+ Hits 19084 19304 +220
+ Misses 2749 2601 -148
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@gpucibot merge |
Description
Refactors the main device code used for
cudf::strings::pad
andcudf::strings::zfill
for reuse in strings UDF pad and zfill functions. No new functions or features have been added, updated, or removed. The detail functions have been mainly just be moved to new filecpp/include/cudf/strings/detail/pad_impl.cuh
Checklist