Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pad/zfill functions for reuse with strings udf #11914

Merged
merged 7 commits into from
Oct 19, 2022

Conversation

davidwendt
Copy link
Contributor

Description

Refactors the main device code used for cudf::strings::pad and cudf::strings::zfill for reuse in strings UDF pad and zfill functions. No new functions or features have been added, updated, or removed. The detail functions have been mainly just be moved to new file cpp/include/cudf/strings/detail/pad_impl.cuh

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 13, 2022
@davidwendt davidwendt self-assigned this Oct 13, 2022
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 87.40% // Head: 88.12% // Increases project coverage by +0.71% 🎉

Coverage data is based on head (f6e8da0) compared to base (f72c4ce).
Patch coverage: 88.48% of modified lines in pull request are covered.

❗ Current head f6e8da0 differs from pull request most recent head 148f7b4. Consider uploading reports for the commit 148f7b4 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11914      +/-   ##
================================================
+ Coverage         87.40%   88.12%   +0.71%     
================================================
  Files               133      133              
  Lines             21833    21905      +72     
================================================
+ Hits              19084    19304     +220     
+ Misses             2749     2601     -148     
Impacted Files Coverage Δ
python/cudf/cudf/core/udf/__init__.py 97.05% <ø> (+47.05%) ⬆️
python/cudf/cudf/io/orc.py 92.94% <ø> (-0.09%) ⬇️
python/cudf/cudf/testing/dataset_generator.py 72.83% <ø> (-0.42%) ⬇️
...thon/dask_cudf/dask_cudf/tests/test_distributed.py 18.86% <ø> (+4.94%) ⬆️
python/cudf/cudf/core/_base_index.py 82.20% <43.75%> (-3.35%) ⬇️
python/cudf/cudf/io/text.py 91.66% <66.66%> (-8.34%) ⬇️
python/strings_udf/strings_udf/__init__.py 84.31% <76.00%> (-12.57%) ⬇️
python/cudf/cudf/core/index.py 92.96% <95.71%> (+0.33%) ⬆️
python/cudf/cudf/__init__.py 90.69% <100.00%> (ø)
python/cudf/cudf/_lib/strings/__init__.py 100.00% <100.00%> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 13, 2022
@davidwendt davidwendt marked this pull request as ready for review October 13, 2022 19:39
@davidwendt davidwendt requested a review from a team as a code owner October 13, 2022 19:39
cpp/src/strings/padding.cu Outdated Show resolved Hide resolved
@davidwendt davidwendt requested a review from ttnghia October 14, 2022 12:05
@upsj upsj self-requested a review October 17, 2022 12:30
Copy link
Contributor

@upsj upsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cpp/include/cudf/strings/detail/pad_impl.cuh Outdated Show resolved Hide resolved
@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 08e4ec2 into rapidsai:branch-22.12 Oct 19, 2022
@davidwendt davidwendt deleted the refactor-pad-zfill branch October 19, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants