Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add nanosecond & microsecond to DatetimeProperties #11911

Merged
merged 67 commits into from
Oct 17, 2022
Merged

[REVIEW] Add nanosecond & microsecond to DatetimeProperties #11911

merged 67 commits into from
Oct 17, 2022

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Oct 12, 2022 •
edited
Loading

Description

This PR:

  • Implemented extract_milli_second, extract_micro_second and extract_nano_second in libcudf.
  • Added nanosecond and microsecond in DatetimeProperties & DatetimeIndex.
  • Updated docs
  • Added & modified tests

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

galipremsagar and others added 30 commits September 18, 2022 15:03
@galipremsagar
fixes
8ff8f95
@galipremsagar
Merge remote-tracking branch 'upstream/branch-22.10' into 11155
ca58733
@galipremsagar
fix repr
579b6b1
@galipremsagar
fix
c625018
@galipremsagar
Update python/cudf/cudf/core/column/datetime.py
148d0f8
@galipremsagar
flake 8
97debb2
@galipremsagar
docs
af4a94d
@galipremsagar
more changes
2b26c15
@galipremsagar
fix docstring
87421b1
@galipremsagar
add datetime overflow tests
cf5e6fb
@galipremsagar
cleanup
b5ea2cc
@galipremsagar
Merge remote-tracking branch 'upstream/branch-22.10' into 11155
67c416b
@galipremsagar
rename
5c3ac19
@galipremsagar
Merge branch 'rapidsai:branch-22.10' into 11155
81d5e51
@galipremsagar
Merge remote-tracking branch 'upstream/branch-22.10' into 11155
014c141
@galipremsagar
Merge remote-tracking branch 'upstream/branch-22.10' into 11155
5ec1079
@galipremsagar
add cpp tests
d690063
@galipremsagar
Merge branch '11155' of https://github.com/galipremsagar/cudf into 11155
ee4997a
@galipremsagar
Merge remote-tracking branch 'upstream/branch-22.10' into 11155
9c30dd7
@galipremsagar
fix test
8d66fc0
@galipremsagar
Merge branch 'rapidsai:branch-22.10' into 11155
cc3e486
@galipremsagar
Merge remote-tracking branch 'upstream/branch-22.10' into 11155
12c8f1b
@galipremsagar
Merge remote-tracking branch 'upstream/branch-22.10' into 11155
da26425
@galipremsagar
move logic to as_string_column
6d556e1
@galipremsagar
todo
9c5a2df
@galipremsagar @davidwendt
Update cpp/src/datetime/datetime_ops.cu
b48155e 
Co-authored-by: David Wendt <[email protected]>
@galipremsagar
Update cpp/src/datetime/datetime_ops.cu
09a9986
@galipremsagar
rename API name
0438b71
@galipremsagar @davidwendt
Update cpp/include/cudf/datetime.hpp
76d4234 
Co-authored-by: David Wendt <[email protected]>
@galipremsagar
add examples
b0750ca
mythrocks
mythrocks approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for accommodating the changes, @galipremsagar.

@galipremsagar galipremsagar removed the 4 - Needs Review Waiting for reviewer to review or respond label Oct 12, 2022
bdice
bdice requested changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some concerns about correctness / pandas alignment.

docs/cudf/source/api_docs/series.rst Outdated Show resolved Hide resolved
python/cudf/cudf/core/series.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/series.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/series.py Show resolved Hide resolved
python/cudf/cudf/tests/test_datetime.py Show resolved Hide resolved
python/cudf/cudf/core/series.py Outdated Show resolved Hide resolved
@galipremsagar galipremsagar requested a review from bdice October 13, 2022 19:49
@galipremsagar galipremsagar changed the title [REVIEW] Add nanosecond, microsecond & millisecond to DatetimeProperties [REVIEW] Add nanosecond & microsecond to DatetimeProperties Oct 14, 2022
galipremsagar
galipremsagar commented Oct 14, 2022
View reviewed changes
docs/cudf/source/api_docs/series.rst Outdated Show resolved Hide resolved
docs/cudf/source/api_docs/index_objects.rst Outdated Show resolved Hide resolved
bdice
bdice approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving after we resolve one dtype issue: #11911 (comment)

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Oct 17, 2022
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit edc058f into rapidsai:branch-22.12 Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvdbaranec nvdbaranec nvdbaranec approved these changes

@davidwendt davidwendt davidwendt approved these changes

@mroeschke mroeschke mroeschke approved these changes

@ttnghia ttnghia ttnghia approved these changes

@mythrocks mythrocks mythrocks approved these changes

@bdice bdice bdice approved these changes

@skirui-source skirui-source Awaiting requested review from skirui-source skirui-source is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
Pandas API Alignment and Coverage
Development

Successfully merging this pull request may close these issues.
7 participants
@galipremsagar @bdice @mythrocks @ttnghia @mroeschke @davidwendt @nvdbaranec