Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thrust output iterator fix (1805) to thrust.patch #11900

Merged
merged 4 commits into from
Oct 13, 2022

Conversation

davidwendt
Copy link
Contributor

Description

Adds fix from NVIDIA/thrust#1805 to libcudf's thrust.patch

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 11, 2022
@davidwendt davidwendt self-assigned this Oct 11, 2022
@github-actions github-actions bot added the CMake CMake build issue label Oct 11, 2022
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidwendt !

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 87.40% // Head: 86.86% // Decreases project coverage by -0.54% ⚠️

Coverage data is based on head (267af10) compared to base (f72c4ce).
Patch coverage: 86.42% of modified lines in pull request are covered.

❗ Current head 267af10 differs from pull request most recent head 89fab0b. Consider uploading reports for the commit 89fab0b to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11900      +/-   ##
================================================
- Coverage         87.40%   86.86%   -0.55%     
================================================
  Files               133      133              
  Lines             21833    21881      +48     
================================================
- Hits              19084    19006      -78     
- Misses             2749     2875     +126     
Impacted Files Coverage Δ
python/cudf/cudf/core/udf/__init__.py 50.00% <ø> (ø)
python/cudf/cudf/io/orc.py 92.94% <ø> (-0.09%) ⬇️
python/cudf/cudf/utils/ioutils.py 79.47% <ø> (ø)
...thon/dask_cudf/dask_cudf/tests/test_distributed.py 18.86% <ø> (+4.94%) ⬆️
python/cudf/cudf/core/_base_index.py 82.20% <43.75%> (-3.35%) ⬇️
python/cudf/cudf/io/text.py 91.66% <66.66%> (-8.34%) ⬇️
python/strings_udf/strings_udf/__init__.py 84.31% <76.00%> (-12.57%) ⬇️
python/cudf/cudf/core/index.py 92.91% <95.16%> (+0.28%) ⬆️
python/cudf/cudf/__init__.py 90.69% <100.00%> (ø)
python/cudf/cudf/core/column/categorical.py 89.34% <100.00%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 11, 2022
@davidwendt davidwendt marked this pull request as ready for review October 11, 2022 21:35
@davidwendt davidwendt requested a review from a team as a code owner October 11, 2022 21:35
@vyasr
Copy link
Contributor

vyasr commented Oct 12, 2022

I would suggest waiting for the corresponding thrust PR to get merged, but it looks like it's already approved and they're just deciding which branch to put the changes on so I'm OK merging this sooner.

@harrism
Copy link
Member

harrism commented Oct 13, 2022

@vyasr it can take a while to merge Thrust PRs because they merge into main and have to be careful... (Not to mention their CI takes 50 hours per compiler version!)

@harrism
Copy link
Member

harrism commented Oct 13, 2022

cuDF does use transform_output_iterator so I'm guessing if this change was going to break it, it would have shown up in CI for this PR.

@harrism
Copy link
Member

harrism commented Oct 13, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0ca68c7 into rapidsai:branch-22.12 Oct 13, 2022
@davidwendt davidwendt deleted the thrust-output-itr-patch branch October 13, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants