-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coverage for string UDF tests. #11891
Add coverage for string UDF tests. #11891
Conversation
Codecov ReportBase: 87.40% // Head: 88.10% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #11891 +/- ##
================================================
+ Coverage 87.40% 88.10% +0.69%
================================================
Files 133 133
Lines 21833 21864 +31
================================================
+ Hits 19084 19263 +179
+ Misses 2749 2601 -148
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Codecov is consistently computing the same incorrect merge base for all PRs (f72c4ce). Now investigating why. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this!
@gpucibot merge |
Description
Many PRs are currently showing Codecov patch status check failures that appear to be the result of not uploading coverage reports for the string UDF tests. This PR should enable the missing coverage and ensure that we are actually measuring coverage of these code paths.
Checklist