Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "experimental" warning for struct columns in ORC reader and writer #11880

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Remove "experimental" warning for struct columns in ORC reader and writer #11880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc9bfc0
remove warnings about structs in ORC
vuule Oct 7, 2022
87fcb47
remote sources restore
vuule Oct 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions cpp/include/cudf/io/orc.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,9 +378,6 @@ class orc_reader_options_builder {
* auto result = cudf::io::read_orc(options);
* @endcode
*
* Note: Support for reading files with struct columns is currently experimental, the output may not
* be as reliable as reading for other datatypes.
*
* @param options Settings for controlling reading behavior
* @param mr Device memory resource used to allocate device memory of the table in the returned
* table_with_metadata.
Expand Down Expand Up @@ -783,9 +780,6 @@ class orc_writer_options_builder {
* cudf::io::write_orc(options);
* @endcode
*
* Note: Support for writing tables with struct columns is currently experimental, the output may
* not be as reliable as writing for other datatypes.
*
* @param options Settings for controlling reading behavior
* @param mr Device memory resource to use for device memory allocation
*/
Expand Down
5 changes: 0 additions & 5 deletions python/cudf/cudf/io/orc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,11 +418,6 @@ def to_orc(
"""{docstring}"""

for col in df._data.columns:
if isinstance(col, cudf.core.column.StructColumn):
warnings.warn(
"Support for writing tables with struct columns is "
"currently experimental."
)
if isinstance(col, cudf.core.column.CategoricalColumn):
raise NotImplementedError(
"Writing to ORC format is not yet supported with "
Expand Down
3 changes: 0 additions & 3 deletions python/cudf/cudf/tests/test_orc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1555,7 +1555,6 @@ def test_names_in_struct_dtype_nesting(datadir):
assert edf.dtypes.equals(got.dtypes)


@pytest.mark.filterwarnings("ignore:.*struct.*experimental")
def test_writer_lists_structs(list_struct_buff):
df_in = cudf.read_orc(list_struct_buff)

Expand All @@ -1567,7 +1566,6 @@ def test_writer_lists_structs(list_struct_buff):
assert pyarrow_tbl.equals(df_in.to_arrow())


@pytest.mark.filterwarnings("ignore:.*struct.*experimental")
@pytest.mark.parametrize(
"data",
[
Expand Down Expand Up @@ -1668,7 +1666,6 @@ def test_empty_statistics():
assert stats[0]["i"].get("sum") == 1


@pytest.mark.filterwarnings("ignore:.*struct.*experimental")
@pytest.mark.parametrize(
"equivalent_columns",
[
Expand Down
7 changes: 0 additions & 7 deletions python/cudf/cudf/utils/ioutils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,8 +301,6 @@

Notes
-----
Support for reading files with struct columns is currently experimental,
the output may not be as reliable as reading for other datatypes.
{remote_data_sources}

Examples
Expand Down Expand Up @@ -447,11 +445,6 @@
Note that this option only affects columns of ListDtype. Names of other
column types will be ignored.

Notes
-----
Support for writing tables with struct columns is currently experimental,
the output may not be as reliable as writing for other datatypes.

See Also
--------
cudf.read_orc
Expand Down