-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cudf::stable_sorted_order for NaN and -NaN in FLOAT64 columns #11874
Fix cudf::stable_sorted_order for NaN and -NaN in FLOAT64 columns #11874
Conversation
Codecov ReportBase: 87.40% // Head: 88.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #11874 +/- ##
================================================
+ Coverage 87.40% 88.11% +0.70%
================================================
Files 133 133
Lines 21833 21881 +48
================================================
+ Hits 19084 19281 +197
+ Misses 2749 2600 -149
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This cleans up a lot.
@gpucibot merge |
Description
Fixes bug in
cudf::stable_sorted_order
when-NaN
andNaN
are in a FLOAT64 (double) columns.The code was fixed by refactoring common code with
cudf::sorted_order
. This uses thrust sort functions to help align the behavior and keep results consistent.New gtests were added to check for this case. Some test files were also updated per issue #11734
The new tests are at the bottom of
sort_test.cpp
andstable_sort_tests.cpp
This was found while working on #11729
The sorted-order functions are reused for many of the libcudf sort functions so this will help with the work in #11729
Checklist