Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change expect_strings_empty into expect_column_empty libcudf test utility #11873

Merged
merged 4 commits into from
Oct 12, 2022

Conversation

davidwendt
Copy link
Contributor

Description

Moves the cudf::test::expect_strings_empty utility from cpp/tests/strings to more generic function cudf::test::expect_column_empty

Reference #11734

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. tech debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 6, 2022
@davidwendt davidwendt self-assigned this Oct 6, 2022
@github-actions github-actions bot added the CMake CMake build issue label Oct 6, 2022
@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Base: 87.40% // Head: 87.48% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (6876f16) compared to base (f72c4ce).
Patch coverage: 84.03% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11873      +/-   ##
================================================
+ Coverage         87.40%   87.48%   +0.07%     
================================================
  Files               133      133              
  Lines             21833    21866      +33     
================================================
+ Hits              19084    19130      +46     
+ Misses             2749     2736      -13     
Impacted Files Coverage Δ
python/cudf/cudf/core/udf/__init__.py 50.00% <ø> (ø)
python/cudf/cudf/utils/ioutils.py 79.47% <ø> (ø)
...thon/dask_cudf/dask_cudf/tests/test_distributed.py 18.86% <ø> (+4.94%) ⬆️
python/cudf/cudf/core/_base_index.py 82.20% <43.75%> (-3.35%) ⬇️
python/cudf/cudf/io/text.py 91.66% <66.66%> (-8.34%) ⬇️
python/strings_udf/strings_udf/__init__.py 86.27% <76.00%> (-10.61%) ⬇️
python/cudf/cudf/core/index.py 92.91% <95.08%> (+0.27%) ⬆️
python/cudf/cudf/__init__.py 90.69% <100.00%> (ø)
python/cudf/cudf/core/column/categorical.py 89.34% <100.00%> (ø)
python/cudf/cudf/core/scalar.py 90.52% <100.00%> (+1.25%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 10, 2022
@davidwendt davidwendt marked this pull request as ready for review October 10, 2022 17:37
@davidwendt davidwendt requested review from a team as code owners October 10, 2022 17:37
@davidwendt davidwendt requested review from upsj and vuule October 10, 2022 17:37
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great!

@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ccbd852 into rapidsai:branch-22.12 Oct 12, 2022
@davidwendt davidwendt deleted the expect-column-empty branch October 12, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants