-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ngroup #11871
Add ngroup #11871
Conversation
@@ -121,13 +121,36 @@ cdef class GroupBy: | |||
self.dropna = dropna | |||
|
|||
def groups(self, list values): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to this function are tangential, but I discovered the need for a docstring here, and a bug that would lead to a segfault if values
was empty.
Codecov ReportBase: 87.46% // Head: 87.49% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #11871 +/- ##
================================================
+ Coverage 87.46% 87.49% +0.02%
================================================
Files 133 133
Lines 21792 21880 +88
================================================
+ Hits 19061 19144 +83
- Misses 2731 2736 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also add ngroup
entry to Computations / descriptive stats
group in https://github.com/rapidsai/cudf/blob/branch-22.12/docs/cudf/source/api_docs/groupby.rst
@gpucibot merge |
Description
Adds the
GroupBy.ngroup()
method. Closes #11848Checklist