-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix decimal benchmark input data generation #11863
Fix decimal benchmark input data generation #11863
Conversation
Codecov ReportBase: 87.40% // Head: 87.49% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #11863 +/- ##
================================================
+ Coverage 87.40% 87.49% +0.08%
================================================
Files 133 133
Lines 21833 21830 -3
================================================
+ Hits 19084 19101 +17
+ Misses 2749 2729 -20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@gpucibot merge |
Description
closes #11850
Fixes decimal benchmark input data generation.
Generated data alternated between two values because
device_uvector<T>
has both value and scale. scale is fixed for a column and hence when this data is copied tocudf::column
, this column values alternated between values and scale.Fix is to use
device_storage_type_t<T>
instead ofT
.Checklist