Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decimal benchmark input data generation #11863

Merged

Conversation

karthikeyann
Copy link
Contributor

Description

closes #11850
Fixes decimal benchmark input data generation.
Generated data alternated between two values because device_uvector<T> has both value and scale. scale is fixed for a column and hence when this data is copied to cudf::column, this column values alternated between values and scale.
Fix is to use device_storage_type_t<T> instead of T.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@karthikeyann karthikeyann added bug Something isn't working 3 - Ready for Review Ready for review by team tests Unit testing for project 4 - Needs cuIO Reviewer non-breaking Non-breaking change labels Oct 5, 2022
@karthikeyann karthikeyann requested a review from a team as a code owner October 5, 2022 04:23
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Oct 5, 2022
@karthikeyann karthikeyann requested a review from ttnghia October 5, 2022 05:08
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 87.40% // Head: 87.49% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (99ff519) compared to base (f72c4ce).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11863      +/-   ##
================================================
+ Coverage         87.40%   87.49%   +0.08%     
================================================
  Files               133      133              
  Lines             21833    21830       -3     
================================================
+ Hits              19084    19101      +17     
+ Misses             2749     2729      -20     
Impacted Files Coverage Δ
python/cudf/cudf/core/udf/__init__.py 50.00% <ø> (ø)
python/cudf/cudf/utils/ioutils.py 79.47% <ø> (ø)
...thon/dask_cudf/dask_cudf/tests/test_distributed.py 18.86% <ø> (+4.94%) ⬆️
python/cudf/cudf/__init__.py 90.69% <100.00%> (ø)
python/cudf/cudf/core/scalar.py 90.52% <100.00%> (+1.25%) ⬆️
python/dask_cudf/dask_cudf/sorting.py 93.29% <100.00%> (+2.11%) ⬆️
python/strings_udf/strings_udf/__init__.py 86.27% <100.00%> (-10.61%) ⬇️
python/strings_udf/strings_udf/_typing.py 94.73% <0.00%> (-1.06%) ⬇️
python/cudf/cudf/testing/dataset_generator.py 72.83% <0.00%> (-0.42%) ⬇️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vuule vuule added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Oct 6, 2022
@karthikeyann
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1ef722d into rapidsai:branch-22.12 Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change tests Unit testing for project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Random data generator creates incorrect sequences of decimal elements
4 participants