Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix pre-commit copyright check #11860

Merged
merged 4 commits into from
Oct 10, 2022

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Oct 4, 2022

Description

This PR improves the copyright check script to handle cases where the ancestor branch-* does not have an upstream set.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added the 2 - In Progress Currently a work in progress label Oct 4, 2022
@github-actions github-actions bot added the gpuCI label Oct 4, 2022
@galipremsagar galipremsagar added bug Something isn't working improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed gpuCI improvement Improvement / enhancement to an existing function labels Oct 4, 2022
@github-actions github-actions bot added the gpuCI label Oct 10, 2022
ci/checks/copyright.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 87.40% // Head: 87.48% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (2e8630d) compared to base (f72c4ce).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11860      +/-   ##
================================================
+ Coverage         87.40%   87.48%   +0.07%     
================================================
  Files               133      133              
  Lines             21833    21866      +33     
================================================
+ Hits              19084    19129      +45     
+ Misses             2749     2737      -12     
Impacted Files Coverage Δ
python/cudf/cudf/core/udf/__init__.py 50.00% <ø> (ø)
python/cudf/cudf/utils/ioutils.py 79.47% <ø> (ø)
...thon/dask_cudf/dask_cudf/tests/test_distributed.py 18.86% <ø> (+4.94%) ⬆️
python/cudf/cudf/__init__.py 90.69% <100.00%> (ø)
python/cudf/cudf/core/scalar.py 90.52% <100.00%> (+1.25%) ⬆️
python/dask_cudf/dask_cudf/sorting.py 93.29% <100.00%> (+2.11%) ⬆️
python/strings_udf/strings_udf/__init__.py 86.27% <100.00%> (-10.61%) ⬇️
python/cudf/cudf/io/text.py 91.66% <0.00%> (-8.34%) ⬇️
python/cudf/cudf/core/_base_index.py 82.20% <0.00%> (-3.35%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@galipremsagar galipremsagar marked this pull request as ready for review October 10, 2022 18:46
@galipremsagar galipremsagar requested a review from a team as a code owner October 10, 2022 18:46
@galipremsagar galipremsagar changed the title [WIP] Fix pre-commit copyright check [REVIEW] Fix pre-commit copyright check Oct 10, 2022
@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 10, 2022
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested offline with @galipremsagar.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Oct 10, 2022
@bdice
Copy link
Contributor

bdice commented Oct 10, 2022

@gpucibot merge

1 similar comment
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 586907b into rapidsai:branch-22.12 Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants