Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused includes for table/row_operators #11857

Conversation

GregoryKimball
Copy link
Contributor

@GregoryKimball GregoryKimball commented Oct 4, 2022

Description

After reviewing usages of the "legacy" row operators, several of the includes are no longer needed.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@GregoryKimball GregoryKimball added code quality libcudf Affects libcudf (C++/CUDA) code. labels Oct 4, 2022
@GregoryKimball GregoryKimball requested a review from a team as a code owner October 4, 2022 03:04
@GregoryKimball GregoryKimball added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 4, 2022
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 87.49% // Head: 87.52% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (3369ee4) compared to base (dfd3d89).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11857      +/-   ##
================================================
+ Coverage         87.49%   87.52%   +0.03%     
================================================
  Files               133      133              
  Lines             21807    21807              
================================================
+ Hits              19079    19087       +8     
+ Misses             2728     2720       -8     
Impacted Files Coverage Δ
python/cudf/cudf/core/dataframe.py 93.77% <0.00%> (+0.04%) ⬆️
python/cudf/cudf/core/column/string.py 88.55% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.22% <0.00%> (+0.21%) ⬆️
python/cudf/cudf/core/column/numerical.py 95.49% <0.00%> (+0.28%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 93.75% <0.00%> (+0.96%) ⬆️
python/strings_udf/strings_udf/__init__.py 96.87% <0.00%> (+3.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ajschmidt8 ajschmidt8 changed the title Remove unused includes for table/row_operators Remove unused includes for table/row_operators Oct 4, 2022
@ajschmidt8 ajschmidt8 changed the title Remove unused includes for table/row_operators Remove unused includes for table/row_operators Oct 4, 2022
@GregoryKimball
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0fb4d76 into rapidsai:branch-22.12 Oct 4, 2022
@GregoryKimball GregoryKimball deleted the remove-include-row-operators branch October 4, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants