Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset strings_udf CEC and solve several related issues #11846

Merged
merged 4 commits into from
Oct 3, 2022
Merged

Reset strings_udf CEC and solve several related issues #11846

merged 4 commits into from
Oct 3, 2022

Conversation

brandon-b-miller
Copy link
Contributor

This PR:

  • Turns CEC off for strings_udf
  • Incorporates a change needed to correctly build strings_udf for a range of supported architectures
  • Fixes a small mistake in strings_udf testing which reran the whole test suite rather than just the UDF tests.

@brandon-b-miller brandon-b-miller requested review from a team as code owners October 3, 2022 14:04
@github-actions github-actions bot added CMake CMake build issue Python Affects Python cuDF API. gpuCI labels Oct 3, 2022
@brandon-b-miller brandon-b-miller added bug Something isn't working non-breaking Non-breaking change and removed gpuCI Python Affects Python cuDF API. CMake CMake build issue labels Oct 3, 2022
@github-actions github-actions bot added CMake CMake build issue Python Affects Python cuDF API. gpuCI labels Oct 3, 2022
@codecov
Copy link

codecov bot commented Oct 3, 2022 •
edited
Loading

Codecov Report

Base: 87.46% // Head: 87.52% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (9896770) compared to base (3f9b3fe).
Patch coverage: 56.09% of modified lines in pull request are covered.

Additional details and impacted files 
@@               Coverage Diff                @@
##           branch-22.10   #11846      +/-   ##
================================================
+ Coverage         87.46%   87.52%   +0.05%     
================================================
  Files               133      133              
  Lines             21792    21807      +15     
================================================
+ Hits              19061    19087      +26     
+ Misses             2731     2720      -11
Impacted Files Coverage Δ
python/cudf/cudf/core/udf/__init__.py 50.00% <15.00%> (-1.62%) ⬇️
python/strings_udf/strings_udf/__init__.py 96.87% <95.23%> (+1.87%) ⬆️
python/cudf/cudf/core/dataframe.py 93.77% <0.00%> (+0.04%) ⬆️
python/cudf/cudf/core/column/string.py 88.55% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.22% <0.00%> (+0.21%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 93.75% <0.00%> (+0.96%) ⬆️
python/strings_udf/strings_udf/_typing.py 94.73% <0.00%> (+7.36%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

robertmaynard
robertmaynard reviewed Oct 3, 2022
View reviewed changes
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake and root build.sh changes LGTM

gmarkall
gmarkall approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@gmarkall gmarkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - this appears to disable CEC for String UDFs without touching cubinlinker-related code in general.

vyasr
vyasr approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment but nothing blocking. LGTM.

ci/gpu/build.sh Show resolved Hide resolved
python/strings_udf/cpp/CMakeLists.txt Show resolved Hide resolved
jolorunyomi
jolorunyomi approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@jolorunyomi jolorunyomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks out

@jolorunyomi jolorunyomi merged commit d9ddd83 into rapidsai:branch-22.10 Oct 3, 2022
@robertmaynard robertmaynard mentioned this pull request Oct 3, 2022
Closed
3 tasks
@brandon-b-miller brandon-b-miller mentioned this pull request Oct 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard left review comments

@jolorunyomi jolorunyomi jolorunyomi approved these changes

@shwina shwina shwina approved these changes

@vyasr vyasr vyasr approved these changes

@gmarkall gmarkall gmarkall approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working CMake CMake build issue non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@brandon-b-miller @robertmaynard @gmarkall @vyasr @shwina @jolorunyomi