Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cudf_io namespace alias #11827

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Sep 29, 2022

Description

Some cuIO tests and benchmarks declare cudf_io alias for cudf::io. This saves a single letter so it's considered to be of very low utility.

Removing all occurrences of this alias.
Also removed a couple of builder calls where the option was being set to default value.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vuule vuule added cuIO cuIO issue tech debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 29, 2022
@vuule vuule self-assigned this Sep 29, 2022
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Sep 29, 2022
@vuule vuule marked this pull request as ready for review September 30, 2022 01:32
@vuule vuule requested a review from a team as a code owner September 30, 2022 01:32
@vuule vuule requested review from bdice and elstehle September 30, 2022 01:32
@vuule vuule added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Oct 3, 2022
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 87.40% // Head: 87.52% // Increases project coverage by +0.11% 🎉

Coverage data is based on head (a594c67) compared to base (f72c4ce).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11827      +/-   ##
================================================
+ Coverage         87.40%   87.52%   +0.11%     
================================================
  Files               133      133              
  Lines             21833    21825       -8     
================================================
+ Hits              19084    19103      +19     
+ Misses             2749     2722      -27     
Impacted Files Coverage Δ
python/cudf/cudf/utils/ioutils.py 79.47% <ø> (ø)
...thon/dask_cudf/dask_cudf/tests/test_distributed.py 18.86% <ø> (+4.94%) ⬆️
python/cudf/cudf/core/scalar.py 90.52% <100.00%> (+1.25%) ⬆️
python/dask_cudf/dask_cudf/sorting.py 93.29% <100.00%> (+2.11%) ⬆️
python/strings_udf/strings_udf/_typing.py 94.73% <0.00%> (-1.06%) ⬇️
python/cudf/cudf/testing/dataset_generator.py 72.83% <0.00%> (-0.42%) ⬇️
python/cudf/cudf/__init__.py 90.69% <0.00%> (ø)
python/strings_udf/strings_udf/__init__.py 97.50% <0.00%> (+0.62%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vuule
Copy link
Contributor Author

vuule commented Oct 3, 2022

rerun tests

@vuule
Copy link
Contributor Author

vuule commented Oct 3, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0b28d34 into rapidsai:branch-22.12 Oct 3, 2022
@vuule vuule deleted the remove-cudf_io-namespace branch October 3, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants