Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert problematic shuffle=explicit-comms changes #11803

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

rjzamora
Copy link
Member

Description

Due to some unfortunate issues with #11576 and rapidsai/dask-cuda#992, I feel that these PRs should be reverted before the 22.10 release. This PRs roll back some recent changes that allow users to explicitly pass shuffle="explicit-comms" to certain shuffle-based algorithms.

cc @wence-

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rjzamora rjzamora added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Sep 28, 2022
@rjzamora rjzamora requested a review from a team as a code owner September 28, 2022 15:49
@github-actions github-actions bot added the Python Affects Python cuDF API. label Sep 28, 2022
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Sep 28, 2022
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@5a416a0). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.10   #11803   +/-   ##
===============================================
  Coverage                ?   87.51%           
===============================================
  Files                   ?      133           
  Lines                   ?    21801           
  Branches                ?        0           
===============================================
  Hits                    ?    19080           
  Misses                  ?     2721           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rjzamora
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 9e9ba6e into rapidsai:branch-22.10 Sep 28, 2022
@rjzamora rjzamora deleted the revert-11576 branch September 28, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants