Tell jitify_preprocess where to search for libnvrtc #11787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
bug
github-actions
bot
added
CMake
robertmaynard
force-pushed
the
bug/ensure_jit_compilation_uses_nvrtc_from_same_cuda
branch
from
ffeeddc to
dfe1a24
Compare
Codecov ReportBase: 87.40% // Head: 87.52% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #11787 +/- ##
================================================
+ Coverage 87.40% 87.52% +0.11%
================================================
Files 133 133
Lines 21833 21807 -26
================================================
+ Hits 19084 19087 +3
+ Misses 2749 2720 -29
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
rerun tests |
robertmaynard
force-pushed
the
bug/ensure_jit_compilation_uses_nvrtc_from_same_cuda
branch
from
dfe1a24 to
91dfa83
Compare
On machines with multiple CUDA Toolkits installed it is possible to have a mismatch between the version of `nvcc` used to compile code and the version of `libnvrtc` used for the JIT code. This generally occurs when `LD_LIBRARY_PATH` points to a different version of the CUDA Toolkit. We now explicitly specify what toolkit library directory to search when JIT code during libcudf compilation.
robertmaynard
force-pushed
the
bug/ensure_jit_compilation_uses_nvrtc_from_same_cuda
branch
from
91dfa83 to
24932d7
Compare
vyasr
approved these changes
Oct 17, 2022
|
@gpucibot merge |
robertmaynard
deleted the
bug/ensure_jit_compilation_uses_nvrtc_from_same_cuda
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On machines with multiple CUDA Toolkits installed it is possible to have a mismatch between the version of
nvccused to compile code and the version oflibnvrtcused for the JIT code. This generally occurs whenLD_LIBRARY_PATHpoints to a different version of the CUDA Toolkit.We now explicitly specify what toolkit library directory to search when JIT code during libcudf compilation.
Checklist