add V2 page header support to parquet reader #11778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #11778 +/- ##
===============================================
Coverage ? 88.14%
===============================================
Files ? 133
Lines ? 21982
Branches ? 0
===============================================
Hits ? 19376
Misses ? 2606
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
rerun tests |
1 similar comment
|
rerun tests |
vuule
reviewed
Oct 7, 2022
Co-authored-by: Vukasin Milovanovic <[email protected]>
vuule
requested changes
Oct 7, 2022
hyperbolic2346
approved these changes
Oct 20, 2022
mroeschke
reviewed
Oct 20, 2022
mroeschke
approved these changes
Oct 20, 2022
vuule
added
5 - Ready to Merge
|
@gpucibot merge |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for reading parquet files with V2 page headers. Fixes #11686
Submitting as draft for now because I'm not sure how to do unit tests for this. libcudf cannot produce files with V2 headers, so I would need to either add files to a data directory somewhere, or add raw binary of some parquet files to parquet_test.cpp. Given the comment on theDecimalReadtest, neither seems attractive. Suggestions are welcome. Perhaps use python to test?Checklist