[gpuCI] Forward-merge branch-22.10 to branch-22.12 [skip gpuci] #11773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes logic in `cudf::lists::sort_lists` handling of sorting floating-point values containing `NaN`, `-NaN`, `Infinity` and `-Infinity`. For large lists (elements >100) of any numeric type, the `cub::DeviceSegmentedRadixSort` is used for sorting. This function sorts using bit values and results in `-NaN` values sorted to the front. Smaller lists and non-numeric types use the libcudf row-operator sorting. The logic fix in this PR bypasses the radix-sort for floating-point values. This is consistent with other sort logic which uses radix-sort similarly: https://github.com/rapidsai/cudf/blob/972708afcfaca006a8483a133dfacd540f232ef1/cpp/src/sort/sort_column.cu#L34 A gtest was also added to verify the fix. Closes #11630 Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Robert (Bobby) Evans (https://github.com/revans2) - Nghia Truong (https://github.com/ttnghia) - Bradley Dice (https://github.com/bdice) - Mike Wilson (https://github.com/hyperbolic2346) URL: #11703
Allows use of any bit width from 1 to 24 for Parquet dictionary keys. Also removes some more magic numbers and cleans up the dictionary test code. Finishes off changes for #10948. Authors: - Ed Seidl (https://github.com/etseidl) Approvers: - https://github.com/nvdbaranec - Vukasin Milovanovic (https://github.com/vuule) URL: #11580
|
SUCCESS - forward-merge complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to
branch-22.10that creates a PR to keepbranch-22.12up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.