-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Remove kwargs
in read_csv
& to_csv
#11762
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-22.10 #11762 +/- ##
===============================================
Coverage ? 87.52%
===============================================
Files ? 133
Lines ? 21792
Branches ? 0
===============================================
Hits ? 19073
Misses ? 2719
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@gpucibot merge |
Description
Fixes: #11683, #10823
This PR:
kwargs
in CSV reader & writer such that users get clear errors when they misspell a parameter.read_csv
&to_csv
parameters which will now match to pandas.The diff is actually adding
storage_options
toread_csv
&to_csv
after removingkwargs
, and the rest of it all re-ordering appropriately.Checklist