Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Remove kwargs in read_csv & to_csv #11762

Merged
merged 6 commits into from
Sep 27, 2022

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Sep 24, 2022

Description

Fixes: #11683, #10823

This PR:

  • Removes kwargs in CSV reader & writer such that users get clear errors when they misspell a parameter.
  • Re-orders read_csv & to_csv parameters which will now match to pandas.

The diff is actually adding storage_options to read_csv & to_csv after removing kwargs, and the rest of it all re-ordering appropriately.

Checklist

@galipremsagar galipremsagar added Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function breaking Breaking change labels Sep 24, 2022
@galipremsagar galipremsagar self-assigned this Sep 24, 2022
@galipremsagar galipremsagar requested a review from a team as a code owner September 24, 2022 00:26
@galipremsagar galipremsagar requested a review from vuule September 24, 2022 00:26
@codecov
Copy link

codecov bot commented Sep 24, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@e64c2da). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head b824a08 differs from pull request most recent head 0641da1. Consider uploading reports for the commit 0641da1 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.10   #11762   +/-   ##
===============================================
  Coverage                ?   87.52%           
===============================================
  Files                   ?      133           
  Lines                   ?    21792           
  Branches                ?        0           
===============================================
  Hits                    ?    19073           
  Misses                  ?     2719           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Needs cuIO Reviewer labels Sep 27, 2022
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change improvement Improvement / enhancement to an existing function Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cuDF read_csv does not throw an error when an unexpected keyword argument is passed
4 participants