Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduces memory requirements in JSON parser and adds bytes/s and peak memory usage to benchmarks #11732

Merged
merged 5 commits into from
Sep 22, 2022
Merged

Reduces memory requirements in JSON parser and adds bytes/s and peak memory usage to benchmarks #11732

merged 5 commits into from
Sep 22, 2022

Conversation

elstehle
Copy link
Contributor

@elstehle elstehle commented Sep 21, 2022 •
edited
Loading

Description

This PR reduces memory requirements in the new nested JSON parser and adds bytes_per_second and peak_memory_usage usage to benchmarks

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@elstehle elstehle requested a review from a team as a code owner September 21, 2022 14:42
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Sep 21, 2022
@elstehle elstehle added cuIO cuIO issue tech debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 21, 2022
@elstehle elstehle added this to the Nested JSON reader milestone Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@46bd87a). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@               Coverage Diff               @@
##             branch-22.10   #11732   +/-   ##
===============================================
  Coverage                ?   87.54%           
===============================================
  Files                   ?      133           
  Lines                   ?    21769           
  Branches                ?        0           
===============================================
  Hits                    ?    19057           
  Misses                  ?     2712           
  Partials                ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

PointKernel
PointKernel reviewed Sep 22, 2022
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with two nitpicks.

cpp/benchmarks/io/json/nested_json.cpp Outdated Show resolved Hide resolved
cpp/src/io/json/nested_json_gpu.cu Outdated Show resolved Hide resolved
karthikeyann
karthikeyann approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@elstehle
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 204a09c into rapidsai:branch-22.10 Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PointKernel PointKernel PointKernel approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@upsj upsj upsj approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
Nested JSON reader
Development

Successfully merging this pull request may close these issues.
4 participants
@elstehle @upsj @karthikeyann @PointKernel