Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include decimal in supported types for range window order-by columns #11710

Merged

Conversation

mythrocks
Copy link
Contributor

Description

As a follow-up to #11645, this change includes DECIMAL among the list of data-types that may be used in the order-by column for RANGE-based window functions, listed in the exception message.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mythrocks mythrocks requested a review from a team as a code owner September 14, 2022 22:18
@mythrocks mythrocks self-assigned this Sep 14, 2022
@github-actions github-actions bot added the Java Affects Java cuDF API. label Sep 14, 2022
@mythrocks mythrocks added bug Something isn't working Spark Functionality that helps Spark RAPIDS improvement Improvement / enhancement to an existing function labels Sep 14, 2022
@mythrocks mythrocks added non-breaking Non-breaking change and removed bug Something isn't working labels Sep 14, 2022
Copy link
Contributor

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

java/src/main/java/ai/rapids/cudf/Table.java Show resolved Hide resolved
@ttnghia
Copy link
Contributor

ttnghia commented Sep 15, 2022

Need to merge with upstream to resolve CI failures.

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Base: 86.39% // Head: 86.42% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (393b074) compared to base (75d126a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.10   #11710      +/-   ##
================================================
+ Coverage         86.39%   86.42%   +0.02%     
================================================
  Files               145      145              
  Lines             23013    23013              
================================================
+ Hits              19883    19889       +6     
+ Misses             3130     3124       -6     
Impacted Files Coverage Δ
python/cudf/cudf/core/dataframe.py 93.77% <0.00%> (+0.04%) ⬆️
python/cudf/cudf/core/column/string.py 88.53% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.22% <0.00%> (+0.21%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 93.75% <0.00%> (+0.96%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mythrocks
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 972708a into rapidsai:branch-22.10 Sep 19, 2022
@mythrocks mythrocks deleted the fix-window-exception-string branch September 19, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants