Use CubinLinker for CUDA Minor Version Compatibility #11701
Conversation
gmarkall
added
2 - In Progress
| @@ -7,6 +7,7 @@ channels: | |||
| - rapidsai-nightly | |||
| - dask/label/dev | |||
| - conda-forge | |||
| - gmarkall | |||
There was a problem hiding this comment.
For the CI conda build to pick-up from your channel, you will need to have the channel added into build.sh files in the similar way I did in my PR here: https://github.com/rapidsai/cudf/pull/11617/files
There was a problem hiding this comment.
Thanks, I've just seen this whilst I was making a change with a similar aim. I will have a look at the way you did it too.
|
CI errors related to :dask/dask#9490 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-22.10 #11701 +/- ##
===============================================
Coverage ? 86.56%
===============================================
Files ? 133
Lines ? 21781
Branches ? 0
===============================================
Hits ? 18855
Misses ? 2926
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…untime-checks Remove runtime checks for CUDA versions from strings_udf
Co-authored-by: brandon-b-miller <[email protected]>
|
Now that all the required packages are available in the usual channels (Numba 0.56.2 from conda-forge and CubinLinker from rapidsai) I've removed the "DO NOT MERGE" label. Additionally I've added some changes from Brandon that remove the checks on the driver / runtime versions for enabling string UDFs, as the changes in this branch mean that those checks should no longer be necessary. Assuming the tests all pass this should be good for a review / merge if the review is OK. |
gmarkall
added
3 - Ready for Review
|
I opened an integration repo PR: rapidsai/integration#535 |
ci/gpu/build.sh
Outdated
| # retest cudf with strings_udf present | ||
| py.test -n 8 --cache-clear --basetemp="$WORKSPACE/strings-udf-cuda-tmp" --junitxml="$WORKSPACE/junit-strings-udf.xml" -v --cov-config=.coveragerc --cov=strings_udf --cov-report=xml:"$WORKSPACE/python/strings_udf/strings-udf-coverage.xml" --cov-report term tests | ||
| gpuci_logger "Python py.test retest cuDF UDFs" | ||
| py.test tests/test_udf_masked_ops.py -n 8 --cache-clear |
There was a problem hiding this comment.
Is this right? Don't we need to cd $WORKSPACE/python/cudf/cudf between these two lines?
There was a problem hiding this comment.
you're right. Looks like I was a little overzealous with my deletions here @gmarkall , sorry about that!
Co-authored-by: brandon-b-miller <[email protected]>
|
Thanks all! 🎉 |
Description
This switches to using CubinLinker (from PTXCompiler, but CubinLinker uses PTXCompiler internally) for Minor Version Compatibility. This enables support for all Numba features except linking archives with MVC, in support of use cases such as String UDFs (#11319) with MVC.
Checklist