-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default to equal NaNs in make_collect_set_aggregation. #11621
Conversation
rerun tests |
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportBase: 87.40% // Head: 88.13% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #11621 +/- ##
================================================
+ Coverage 87.40% 88.13% +0.72%
================================================
Files 133 133
Lines 21833 21987 +154
================================================
+ Hits 19084 19379 +295
+ Misses 2749 2608 -141
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NaN
was defaulted to UNEQUAL
because that (collect_set
) was implemented as requested for Spark. Anyway, since we have the parameter and Spark explicitly passes in that parameter, the changes in this PR will not cause any breaking.
@gpucibot merge |
Description
Partially resolves #11329. This helps to align our default behaviors for null and NaN equality across APIs, specifically for
make_collect_set_aggregation
in this PR. All functions should default to treating null values as equal to one another and NaN values as equal to one another.Checklist