Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add control of Parquet column index creation to python #11453

Merged
merged 6 commits into from
Sep 1, 2022
Merged

Add control of Parquet column index creation to python #11453

merged 6 commits into from
Sep 1, 2022

Conversation

etseidl
Copy link
Contributor

@etseidl etseidl commented Aug 3, 2022

Description

#11302 added STATISTICS_COLUMN to the statistics_freq enum in libcudf. This adds the same to python.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@etseidl etseidl requested a review from a team as a code owner August 3, 2022 20:30
@etseidl etseidl requested review from vyasr and skirui-source August 3, 2022 20:30
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 3, 2022
@codecov
Copy link

codecov bot commented Aug 3, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@d241458). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@               Coverage Diff               @@
##             branch-22.10   #11453   +/-   ##
===============================================
  Coverage                ?   86.41%           
===============================================
  Files                   ?      145           
  Lines                   ?    22993           
  Branches                ?        0           
===============================================
  Hits                    ?    19870           
  Misses                  ?     3123           
  Partials                ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shwina shwina added the non-breaking Non-breaking change label Aug 8, 2022
shwina
shwina approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We should be using lowercase strings as option names, and accept None instead of 'NONE', but that is orthogonal to this PR.

@shwina shwina added the improvement Improvement / enhancement to an existing function label Aug 8, 2022
vyasr
vyasr approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vyasr
Copy link
Contributor

vyasr commented Aug 29, 2022

rerun tests

1 similar comment
@vyasr
Copy link
Contributor

vyasr commented Aug 30, 2022

rerun tests

@vyasr
Copy link
Contributor

vyasr commented Sep 1, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c273da4 into rapidsai:branch-22.10 Sep 1, 2022
@etseidl etseidl deleted the feature/colidx_python_bindings branch October 21, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwina shwina shwina approved these changes

@vyasr vyasr vyasr approved these changes

@skirui-source skirui-source Awaiting requested review from skirui-source skirui-source is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etseidl @vyasr @shwina