Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix issues with day & night modes in python docs #11400

Merged
merged 7 commits into from
Aug 1, 2022
Merged

[REVIEW] Fix issues with day & night modes in python docs #11400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1d4f907
add proper light and dark theme support
galipremsagar Jul 29, 2022
853e4d5
custom js file
galipremsagar Jul 29, 2022
0bef956
misc fixes
galipremsagar Jul 29, 2022
520242a
rename file
galipremsagar Jul 29, 2022
28d3435
rename
galipremsagar Jul 29, 2022
9f2ad9c
centralize all common code
galipremsagar Jul 29, 2022
a679272
copyright and deletion
galipremsagar Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cpp/doxygen/Doxyfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1156,7 +1156,7 @@ HTML_HEADER =
# that doxygen normally uses.
# This tag requires that the tag GENERATE_HTML is set to YES.

HTML_FOOTER =
HTML_FOOTER = footer.html

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to blank out the filename in this line: HTML_EXTRA_STYLESHEET = rapids.css
Since you've delete the rapids.css

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch, David. Deleted this.

# The HTML_STYLESHEET tag can be used to specify a user-defined cascading style
# sheet that is used by each HTML page. It can be used to fine-tune the look of
Expand All @@ -1181,7 +1181,7 @@ HTML_STYLESHEET =
# list). For an example see the documentation.
# This tag requires that the tag GENERATE_HTML is set to YES.

HTML_EXTRA_STYLESHEET = rapids.css
HTML_EXTRA_STYLESHEET =

# The HTML_EXTRA_FILES tag can be used to specify one or more extra images or
# other source files which should be copied to the HTML output directory. Note
Expand Down
4 changes: 4 additions & 0 deletions cpp/doxygen/footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<!-- Copyright (c) 2022, NVIDIA CORPORATION. -->

<script src="https://docs.rapids.ai/assets/js/custom.js"></script>
<link rel="stylesheet" href="https://docs.rapids.ai/assets/css/custom.css">
119 changes: 0 additions & 119 deletions cpp/doxygen/rapids.css
View file
Open in desktop

This file was deleted.

66 changes: 0 additions & 66 deletions docs/cudf/source/_static/params.css
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion docs/cudf/source/conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,8 @@ def process_class_docstrings(app, what, name, obj, options, lines):
nitpick_ignore = [("py:class", "SeriesOrIndex"),]

def setup(app):
app.add_css_file("params.css")
app.add_css_file("https://docs.rapids.ai/assets/css/custom.css")
app.add_js_file("https://docs.rapids.ai/assets/js/custom.js")
app.connect("doctree-read", resolve_aliases)
app.connect("missing-reference", ignore_internal_references)
app.connect("autodoc-process-docstring", process_class_docstrings)