Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow CuPy 11 #11393

Merged
merged 3 commits into from
Jul 29, 2022
Merged

Allow CuPy 11 #11393

merged 3 commits into from
Jul 29, 2022

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Jul 28, 2022 •
edited
Loading

Description

Allows cuDF to be installed with CuPy 11.

xref: rapidsai/integration#508

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jakirkham jakirkham requested a review from a team as a code owner July 28, 2022 17:59
@github-actions github-actions bot added the conda label Jul 28, 2022
@jakirkham jakirkham added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 28, 2022
@jakirkham jakirkham requested a review from a team as a code owner July 28, 2022 19:59
@jakirkham jakirkham requested review from bdice and mroeschke July 28, 2022 19:59
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 28, 2022
@jakirkham jakirkham mentioned this pull request Jul 28, 2022
Merged
@jakirkham
Copy link
Member Author

cc @quasiben (for awareness)

@jakirkham jakirkham requested a review from a team as a code owner July 28, 2022 20:08
@codecov
Copy link

codecov bot commented Jul 28, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@c11b780). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head c169ed8 differs from pull request most recent head 696d12b. Consider uploading reports for the commit 696d12b to get more accurate results

@@               Coverage Diff               @@
##             branch-22.08   #11393   +/-   ##
===============================================
  Coverage                ?   86.43%           
===============================================
  Files                   ?      144           
  Lines                   ?    22808           
  Branches                ?        0           
===============================================
  Hits                    ?    19714           
  Misses                  ?     3094           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c11b780...696d12b. Read the comment docs.

@jakirkham
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit eb2e93f into rapidsai:branch-22.08 Jul 29, 2022
@jakirkham jakirkham deleted the allow_cupy_11 branch July 29, 2022 00:25
@jakirkham
Copy link
Member Author

Thanks all! 🙏

@shwina
Copy link
Contributor

shwina commented Jul 29, 2022 •
edited
Loading

I think we missed cudf_dev_cuda11.5.yml here.

@jakirkham jakirkham mentioned this pull request Jul 29, 2022
Closed
3 tasks
@jakirkham
Copy link
Member Author

I think we missed cudf_dev_cuda11.5.yml here.

Good catch. Submitted PR ( #11405 ) to add that.

jakirkham added a commit to jakirkham/cudf that referenced this pull request Jul 29, 2022
@jakirkham
Revert "Allow CuPy 11 (rapidsai#11393)"
cb081a2 
This reverts commit eb2e93f.
@jakirkham jakirkham mentioned this pull request Jul 29, 2022
Merged
3 tasks
@jakirkham
Copy link
Member Author

Reverting in PR ( #11409 ).

rapids-bot bot pushed a commit that referenced this pull request Aug 1, 2022
@jakirkham
Revert "Allow CuPy 11" (#11409)
736531b 
This reverts PR ( #11393 ). Thus constraining this back to CuPy 10.

Authors:
  - https://github.com/jakirkham

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Michael Wang (https://github.com/isVoid)
  - Ashwin Srinath (https://github.com/shwina)
  - Jordan Jacobelli (https://github.com/Ethyling)

URL: #11409
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@sevagh sevagh sevagh approved these changes

@bdice bdice bdice approved these changes

@thomcom thomcom thomcom approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jakirkham @shwina @thomcom @bdice @sevagh @mroeschke