Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contributing doc to include links to the developer guides #11390

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Update contributing doc to include links to the developer guides #11390

merged 2 commits into from
Jul 29, 2022

Conversation

davidwendt
Copy link
Contributor

Description

Adds links to the developer guides to the contributing.md

Closes #11348

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress doc Documentation non-breaking Non-breaking change labels Jul 28, 2022
@davidwendt davidwendt self-assigned this Jul 28, 2022
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jul 28, 2022
@davidwendt davidwendt marked this pull request as ready for review July 28, 2022 14:35
@davidwendt davidwendt mentioned this pull request Jul 28, 2022
Closed
@davidwendt davidwendt requested review from a team, vyasr, karthikeyann and skirui-source and removed request for a team July 28, 2022 21:47
harrism
harrism approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @davidwendt ! Looks good.

vyasr
vyasr approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks David.

docs/cudf/README.md Show resolved Hide resolved
@vyasr
Copy link
Contributor

vyasr commented Jul 29, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a68e6e6 into rapidsai:branch-22.10 Jul 29, 2022
@davidwendt davidwendt deleted the doc-contrib-develop-guide branch February 16, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@harrism harrism harrism approved these changes

@karthikeyann karthikeyann Awaiting requested review from karthikeyann karthikeyann was automatically assigned from rapidsai/cudf-cpp-codeowners

@skirui-source skirui-source Awaiting requested review from skirui-source skirui-source was automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @vyasr @harrism