-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove HASH_SERIAL_MURMUR3 / serial32BitMurmurHash3 #11383
Remove HASH_SERIAL_MURMUR3 / serial32BitMurmurHash3 #11383
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.10 #11383 +/- ##
===============================================
Coverage ? 86.43%
===============================================
Files ? 144
Lines ? 22808
Branches ? 0
===============================================
Hits ? 19713
Misses ? 3095
Partials ? 0 Continue to review full report at Codecov.
|
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cython approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. Gotta like negative lines of code.
@gpucibot merge |
Description
This PR closes #11296. While implementing Spark list hashing in #11292, I noticed that
HASH_SERIAL_MURMUR3
does not appear to be used except in tests. It is not exposed in Python. While it is exposed in the JNI bindings, it is not used by spark-rapids. I discussed this with @rwlee and it seems that this feature was added only for parallel design with the Spark serial hash implementation in #6781, which is superseded by #11292. We do not need to keep this vestigial feature.Checklist