Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Spark list hashing Java tests #11379

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Add Spark list hashing Java tests #11379

merged 2 commits into from
Aug 1, 2022

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jul 28, 2022

Description

This PR adds Java tests for the Spark list hashing feature added in #11292.

Depends on #11292.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the Java Affects Java cuDF API. label Jul 28, 2022
@bdice bdice mentioned this pull request Jul 28, 2022
Merged
@codecov
Copy link

codecov bot commented Jul 28, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@2288d5b). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.10   #11379   +/-   ##
===============================================
  Coverage                ?   86.43%           
===============================================
  Files                   ?      143           
  Lines                   ?    22777           
  Branches                ?        0           
===============================================
  Hits                    ?    19687           
  Misses                  ?     3090           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2288d5b...f2a14d6. Read the comment docs.

@bdice bdice added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function tests Unit testing for project labels Jul 28, 2022
@bdice bdice marked this pull request as ready for review July 28, 2022 17:05
@bdice bdice requested a review from a team as a code owner July 28, 2022 17:05
@bdice bdice assigned bdice and unassigned rwlee Jul 28, 2022
@bdice bdice requested review from rwlee and ttnghia July 28, 2022 17:05
@bdice
Copy link
Contributor Author

bdice commented Aug 1, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 35a7c81 into rapidsai:branch-22.10 Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@jlowe jlowe jlowe approved these changes

@rwlee rwlee Awaiting requested review from rwlee

Assignees

@bdice bdice

@rwlee rwlee

Labels
improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change tests Unit testing for project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdice @jlowe @ttnghia @rwlee