Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to_timestamps truncated subsecond calculation #11367

Merged

Conversation

davidwendt
Copy link
Contributor

Description

Fix truncated subsecond calculation to adjust for the actual digits read in decimal 10 notation.
Added new test strings to include an appended 'Z' after the subsecond digits to test this fix.

Closes #11350

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Jul 27, 2022
@davidwendt davidwendt self-assigned this Jul 27, 2022
@davidwendt
Copy link
Contributor Author

This reminds me of quote from Young Frankenstein where Dr. Frankenstein is reading his grandfather's notes just before he shouts "It could work!" The solution he found was to change the poles from plus to minus and
image

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@150abc8). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.10   #11367   +/-   ##
===============================================
  Coverage                ?   86.43%           
===============================================
  Files                   ?      143           
  Lines                   ?    22777           
  Branches                ?        0           
===============================================
  Hits                    ?    19687           
  Misses                  ?     3090           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 150abc8...ac6edb6. Read the comment docs.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jul 28, 2022
@davidwendt davidwendt marked this pull request as ready for review July 28, 2022 13:22
@davidwendt davidwendt requested a review from a team as a code owner July 28, 2022 13:22
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 9bed351 into rapidsai:branch-22.10 Jul 29, 2022
@davidwendt davidwendt deleted the bug-to-tstamp-trunc-subsec branch July 29, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants