Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused custreamz thirdparty directory #11343

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Remove unused custreamz thirdparty directory #11343

merged 1 commit into from
Jul 28, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jul 25, 2022 •
edited
Loading

Description

Closes #10918

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 3 - Ready for Review Ready for review by team tech debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 25, 2022
@vyasr vyasr requested a review from a team as a code owner July 25, 2022 16:14
@vyasr vyasr self-assigned this Jul 25, 2022
@vyasr vyasr requested review from bdice and isVoid July 25, 2022 16:14
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 25, 2022
galipremsagar
galipremsagar approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @jdye64 for visibility

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Jul 25, 2022
@jdye64
Copy link
Contributor

jdye64 commented Jul 25, 2022

cc: @jdye64 for visibility

Thanks for the heads-up, yep that is totally fine.

@vyasr
Copy link
Contributor Author

vyasr commented Jul 26, 2022

rerun tests

1 similar comment
@vyasr
Copy link
Contributor Author

vyasr commented Jul 28, 2022

rerun tests

@codecov
Copy link

codecov bot commented Jul 28, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@df24808). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.10   #11343   +/-   ##
===============================================
  Coverage                ?   86.43%           
===============================================
  Files                   ?      143           
  Lines                   ?    22777           
  Branches                ?        0           
===============================================
  Hits                    ?    19687           
  Misses                  ?     3090           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df24808...c149f2d. Read the comment docs.

@bdice
Copy link
Contributor

bdice commented Jul 28, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 617cb80 into rapidsai:branch-22.10 Jul 28, 2022
@vyasr vyasr mentioned this pull request Jul 29, 2022
Closed
@vyasr vyasr deleted the fix/issue_10918 branch January 23, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@bdice bdice bdice approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@vyasr vyasr

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vyasr @jdye64 @bdice @galipremsagar