Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table_view_base doxygen format #11340

Merged
merged 8 commits into from
Jul 28, 2022

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Jul 25, 2022

Description

Fixes the formatting of the cudf::table_view_base class doxygen description.
https://docs.rapids.ai/api/libcudf/stable/classcudf_1_1detail_1_1table__view__base.html#details

Closes #11295

New format is as follows:
table_view_base-doxygen

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Jul 25, 2022
@davidwendt davidwendt requested a review from a team as a code owner July 25, 2022 15:14
@davidwendt davidwendt self-assigned this Jul 25, 2022
@davidwendt davidwendt requested review from vyasr and karthikeyann July 25, 2022 15:14
Comment on lines +47 to +48
* @tparam ColumnView The type of column view the table contains:
* expects column_view or mutable_column_view
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @tparam ColumnView The type of column view the table contains:
* expects column_view or mutable_column_view
* @tparam ColumnView The type of column view the table contains.
* Expects column_view or mutable_column_view

Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ttnghia
Copy link
Contributor

ttnghia commented Jul 26, 2022

Rerun tests.

1 similar comment
@ttnghia
Copy link
Contributor

ttnghia commented Jul 26, 2022

Rerun tests.

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@150abc8). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.10   #11340   +/-   ##
===============================================
  Coverage                ?   86.43%           
===============================================
  Files                   ?      143           
  Lines                   ?    22777           
  Branches                ?        0           
===============================================
  Hits                    ?    19687           
  Misses                  ?     3090           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 150abc8...fd92bce. Read the comment docs.

@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8c01690 into rapidsai:branch-22.10 Jul 28, 2022
@davidwendt davidwendt deleted the doc-table-view-base branch July 28, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants