-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for list<int8> columns to be written as byte arrays in parquet #11328
Merged
rapids-bot
merged 64 commits into
rapidsai:branch-22.08
from
hyperbolic2346:mwilson/parquet_list_write
Jul 29, 2022
Merged
Adding support for list<int8> columns to be written as byte arrays in parquet #11328
rapids-bot
merged 64 commits into
rapidsai:branch-22.08
from
hyperbolic2346:mwilson/parquet_list_write
Jul 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pports top level lists
hyperbolic2346
added
feature request
New feature or request
3 - Ready for Review
Ready for review by team
libcudf
Affects libcudf (C++/CUDA) code.
5 - DO NOT MERGE
Hold off on merging; see PR for details
non-breaking
Non-breaking change
labels
Jul 21, 2022
hyperbolic2346
requested review from
mroeschke,
galipremsagar,
harrism and
nvdbaranec
July 21, 2022 23:39
mythrocks
reviewed
Jul 28, 2022
nice fine, thanks Vukasin Co-authored-by: Vukasin Milovanovic <[email protected]>
Co-authored-by: Vukasin Milovanovic <[email protected]>
Co-authored-by: MithunR <[email protected]>
mythrocks
reviewed
Jul 28, 2022
mythrocks
reviewed
Jul 28, 2022
This was referenced Jul 28, 2022
…e during review changes, but I'm not 100% sure yet. Still testing and bisecting.
mythrocks
reviewed
Jul 28, 2022
mythrocks
reviewed
Jul 28, 2022
mythrocks
approved these changes
Jul 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some very minor, optional suggestions for changes.
Apologies for taking so long with this.
Co-authored-by: MithunR <[email protected]>
github-actions
bot
removed
Python
Affects Python cuDF API.
Java
Affects Java cuDF API.
labels
Jul 29, 2022
vuule
approved these changes
Jul 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
feature request
New feature or request
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last major feature in the byte array changes for parquet. This PR enables support for lists of bytes to be written as byte arrays in parquet files. This is a more efficient storage mechanism than what was used before.
Limitations:
This is based on top of #11160 and should not merge until it does. Once that merges, the delta here will reduce a good deal.