Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --output-on-failure to ctest args. #11321

Merged
merged 4 commits into from
Jul 22, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jul 21, 2022

Resolves #3036 by making make test or ninja test default to showing output when tests fail.

@vyasr vyasr added 3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 21, 2022
@vyasr vyasr self-assigned this Jul 21, 2022
@vyasr vyasr requested a review from a team as a code owner July 21, 2022 16:00
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jul 21, 2022
@vyasr
Copy link
Contributor Author

vyasr commented Jul 21, 2022

@robertmaynard is this change too broad in scope? I don't see any obvious way to make this configurable, nor am I sure that it's particularly beneficial to do so. I would say that we either accept this change, or close the associated issue as wontfix. I'm fine with either outcome.

Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since CMAKE_CTEST_ARGUMENTS is evaluated in the context of the root CMakeLists.txt we should instead move this logic to the if(CUDF_BUILD_TESTS) logic where we call include(CTest).

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #11321 (4c66797) into branch-22.08 (edc5062) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 4c66797 differs from pull request most recent head be459f3. Consider uploading reports for the commit be459f3 to get more accurate results

@@               Coverage Diff                @@
##           branch-22.08   #11321      +/-   ##
================================================
+ Coverage         86.34%   86.40%   +0.06%     
================================================
  Files               144      143       -1     
  Lines             22826    22753      -73     
================================================
- Hits              19708    19659      -49     
+ Misses             3118     3094      -24     
Impacted Files Coverage Δ
python/cudf/cudf/_lib/__init__.py 100.00% <ø> (ø)
python/cudf/cudf/core/column/column.py 89.77% <100.00%> (+0.07%) ⬆️
python/cudf/cudf/io/parquet.py 90.93% <100.00%> (+0.09%) ⬆️
python/cudf/cudf/core/dataframe.py 93.57% <0.00%> (+0.04%) ⬆️
python/cudf/cudf/core/column/string.py 88.80% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.02% <0.00%> (+0.21%) ⬆️
python/cudf/cudf/core/column/numerical.py 96.19% <0.00%> (+0.29%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 91.70% <0.00%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edc5062...be459f3. Read the comment docs.

@vyasr vyasr requested a review from a team as a code owner July 21, 2022 21:52
@vyasr
Copy link
Contributor Author

vyasr commented Jul 22, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e4c6f82 into rapidsai:branch-22.08 Jul 22, 2022
@vyasr vyasr deleted the fix/issue_3036 branch January 23, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] CMake does not display output of failing tests by default
3 participants