-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --output-on-failure to ctest args. #11321
Conversation
@robertmaynard is this change too broad in scope? I don't see any obvious way to make this configurable, nor am I sure that it's particularly beneficial to do so. I would say that we either accept this change, or close the associated issue as wontfix. I'm fine with either outcome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since CMAKE_CTEST_ARGUMENTS
is evaluated in the context of the root CMakeLists.txt we should instead move this logic to the if(CUDF_BUILD_TESTS)
logic where we call include(CTest)
.
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #11321 +/- ##
================================================
+ Coverage 86.34% 86.40% +0.06%
================================================
Files 144 143 -1
Lines 22826 22753 -73
================================================
- Hits 19708 19659 -49
+ Misses 3118 3094 -24
Continue to review full report at Codecov.
|
@gpucibot merge |
Resolves #3036 by making
make test
orninja test
default to showing output when tests fail.