Implement lists::distinct and cudf::detail::stable_distinct
#11149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttnghia
added
feature request
This comment was marked as off-topic.
This comment was marked as off-topic.
ttnghia
changed the title
lists::distinctcudf::stable_distinct and lists::distinct
ttnghia
changed the title
cudf::stable_distinct and lists::distinctcudf::detail::stable_distinct and lists::distinct
ttnghia
changed the title
cudf::detail::stable_distinct and lists::distinctlists::distinct and cudf::detail::stable_distinct
ttnghia
added
3 - Ready for Review
robertmaynard
approved these changes
Jun 28, 2022
PointKernel
requested changes
Jun 29, 2022
PointKernel
approved these changes
Jun 30, 2022
This was referenced Jul 8, 2022
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 22, 2022
This PR completely removes `cudf::lists::drop_list_duplicates`. It is replaced by the new API `cudf::list::distinct` which has a simpler implementation but better performance. The replacements for internal cudf usage have all been merged before thus there is no side effect or breaking for the existing APIs in this work. Closes #11114, #11093, #11053, #11034, and closes #9257. Depends on: * #11228 * #11149 * #11234 * #11233 Authors: - Nghia Truong (https://github.com/ttnghia) Approvers: - Jordan Jacobelli (https://github.com/Ethyling) - Robert Maynard (https://github.com/robertmaynard) - Vukasin Milovanovic (https://github.com/vuule) - Bradley Dice (https://github.com/bdice) URL: #11236
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 25, 2022
This PR follows up on #11149 to add the lists filtering (stream compaction) APIs to a doxygen group. The previous doxygen group `lists_drop_duplicates` is empty after #11326. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - David Wendt (https://github.com/davidwendt) - Vukasin Milovanovic (https://github.com/vuule) URL: #11336
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 26, 2022
This PR adds the following APIs for set operations: * `lists::have_overlap` * `lists::intersect_distinct` * `lists::union_distinct` * `lists::difference_distinct` ### Name Convention Except for the first API (`lists::have_overlap`) that returns a boolean column, the suffix `_distinct` of the rest APIs denotes that their results will be lists columns in which all list rows have been post-processed to remove duplicates. As such, their results are actually "set" columns in which each row is a "set" of distinct elements. --- Depends on: * #10945 * #11017 * NVIDIA/cuCollections#175 * #11052 * #11118 * #11100 * #11149 Closes #10409. Authors: - Nghia Truong (https://github.com/ttnghia) - Yunsong Wang (https://github.com/PointKernel) Approvers: - Michael Wang (https://github.com/isVoid) - AJ Schmidt (https://github.com/ajschmidt8) - Bradley Dice (https://github.com/bdice) - Yunsong Wang (https://github.com/PointKernel) URL: #11043
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new APIs:
lists::distinctas a stream compaction component ofcudf::lists::, allowing to extract distinct elements from lists in a lists column. The new API does a similar job aslists::drop_list_duplicatebut can operate on arbitrary data types whilelists::drop_list_duplicatecan only work on basic data types and flat structs.cudf::detail::stable_distinct, which is implemented in the main stream compaction module. This API is introduced as just adetail::API first (which means we can expose it to the public if needed), producing the equivalent output ascudf::distinctbut with row order preserved. It is used as a building block to implementlists::distinct.This PR is a dependency to implement set-like operations (#11043).
Note: This new
lists::distinctAPI will completely replacelists::drop_list_duplicate(which in turn will be deprecated). This will be the follow-up work.