Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated PER_THREAD_DEFAULT_STREAM #11134

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

jbrennan333
Copy link
Contributor

Closes #10862.

The PER_THREAD_DEFAULT_STREAM build option was deprecated in branch-22.06 via #10877, and replaced with the new build option CUDF_USE_PER_THREAD_DEFAULT_STREAM.

This PR removes PER_THREAD_DEFAULT_STREAM.

I am putting this up as a draft because I am not certain if we want to do this in 22.08 or wait for a later release?

@jbrennan333 jbrennan333 added feature request New feature or request CMake CMake build issue tech debt non-breaking Non-breaking change labels Jun 22, 2022
@jbrennan333 jbrennan333 self-assigned this Jun 22, 2022
@github-actions github-actions bot added Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Jun 22, 2022
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@f4f3428). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08   #11134   +/-   ##
===============================================
  Coverage                ?   86.33%           
===============================================
  Files                   ?      144           
  Lines                   ?    22729           
  Branches                ?        0           
===============================================
  Hits                    ?    19624           
  Misses                  ?     3105           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4f3428...377ecad. Read the comment docs.

@jbrennan333 jbrennan333 marked this pull request as ready for review June 22, 2022 19:39
@jbrennan333 jbrennan333 requested review from a team as code owners June 22, 2022 19:39
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java approval

Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's one leftover reference in build.sh. There's also a typo in cpp/CMakeLists.txt, it's missing USE. Let's get those fixed in this PR so that it's a clean transition.

Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops accidentally hit approve instead of request changes 😬

@jbrennan333
Copy link
Contributor Author

Looks like there's one leftover reference in build.sh. There's also a typo in cpp/CMakeLists.txt, it's missing USE. Let's get those fixed in this PR so that it's a clean transition.

Thanks @vyasr! I will fix those.

@jbrennan333
Copy link
Contributor Author

I put up another commit to address the issues raised by @vyasr.

@vyasr
Copy link
Contributor

vyasr commented Jun 23, 2022

LGTM, thanks!

@vyasr
Copy link
Contributor

vyasr commented Jun 23, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4014a65 into rapidsai:branch-22.08 Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue feature request New feature or request Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Rename PER_THREAD_DEFAULT_STREAM cmake option to be unique to cuDF
3 participants