-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated PER_THREAD_DEFAULT_STREAM #11134
Remove deprecated PER_THREAD_DEFAULT_STREAM #11134
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #11134 +/- ##
===============================================
Coverage ? 86.33%
===============================================
Files ? 144
Lines ? 22729
Branches ? 0
===============================================
Hits ? 19624
Misses ? 3105
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Java approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's one leftover reference in build.sh. There's also a typo in cpp/CMakeLists.txt, it's missing USE
. Let's get those fixed in this PR so that it's a clean transition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops accidentally hit approve instead of request changes 😬
Thanks @vyasr! I will fix those. |
I put up another commit to address the issues raised by @vyasr. |
LGTM, thanks! |
@gpucibot merge |
Closes #10862.
The
PER_THREAD_DEFAULT_STREAM
build option was deprecated in branch-22.06 via #10877, and replaced with the new build optionCUDF_USE_PER_THREAD_DEFAULT_STREAM
.This PR removes
PER_THREAD_DEFAULT_STREAM
.I am putting this up as a draft because I am not certain if we want to do this in 22.08 or wait for a later release?