Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compile error due to missing header #11126

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Fix compile error due to missing header #11126

merged 1 commit into from
Jun 20, 2022

Conversation

ttnghia
Copy link
Contributor

@ttnghia ttnghia commented Jun 20, 2022 •
edited
Loading

Some recently merged PRs (#11018 + #11036) do not include enough header which may cause compile error in some systems (in particular, CUDA 11.7 + gcc-11.2). This PR adds the missing header (<optional>) to fix the compile issue.

@ttnghia ttnghia added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Jun 20, 2022
@ttnghia ttnghia requested a review from a team as a code owner June 20, 2022 02:43
@ttnghia ttnghia self-assigned this Jun 20, 2022
@ttnghia ttnghia requested a review from PointKernel June 20, 2022 02:43
@ttnghia ttnghia requested review from jrhemstad, vuule and devavret June 20, 2022 02:43
@codecov
Copy link

codecov bot commented Jun 20, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@0fe5d2d). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 19846b5 differs from pull request most recent head 16ba20c. Consider uploading reports for the commit 16ba20c to get more accurate results

@@               Coverage Diff               @@
##             branch-22.08   #11126   +/-   ##
===============================================
  Coverage                ?   86.33%           
===============================================
  Files                   ?      144           
  Lines                   ?    22729           
  Branches                ?        0           
===============================================
  Hits                    ?    19624           
  Misses                  ?     3105           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fe5d2d...16ba20c. Read the comment docs.

karthikeyann
karthikeyann approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ttnghia
Copy link
Contributor Author

ttnghia commented Jun 20, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4bbb658 into rapidsai:branch-22.08 Jun 20, 2022
@ttnghia ttnghia deleted the fix_compile_errors branch June 21, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PointKernel PointKernel PointKernel approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@jrhemstad jrhemstad Awaiting requested review from jrhemstad jrhemstad is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@vuule vuule Awaiting requested review from vuule

@devavret devavret Awaiting requested review from devavret

Assignees

@ttnghia ttnghia

Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ttnghia @karthikeyann @PointKernel