Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FindcuFile now searches in the current CUDA Toolkit location #11101

Merged
merged 2 commits into from
Jun 16, 2022
Merged

FindcuFile now searches in the current CUDA Toolkit location #11101

merged 2 commits into from
Jun 16, 2022

Conversation

robertmaynard
Copy link
Contributor

@robertmaynard robertmaynard commented Jun 13, 2022 •
edited
Loading

We shouldn't presume that the CUDA Toolkit is always installed at /usr/local/cuda. Instead we use use find_package(CUDAToolkit) to find the correct location.

@robertmaynard
FindcuFile now searches in the current CUDA Toolkit location
7747dc0 
We shouldn't presume that the CUDA Toolkit is always installed
at /usr/local/cuda. Instead we use use `find_package(CUDAToolkit)` to find the correct location.

In addition since `cufile::cuFile_interface` is part of our public interface we also install the `FindcuFile.cmake` file.
@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Jun 13, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner June 13, 2022 17:45
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Jun 13, 2022
@vyasr
Copy link
Contributor

vyasr commented Jun 14, 2022

In addition since cufile::cuFile_interface is part of our public interface we also install the FindcuFile.cmake file.

Were there meant to be changes aside from adding the search hints in this PR?

@robertmaynard
Copy link
Contributor Author

In addition since cufile::cuFile_interface is part of our public interface we also install the FindcuFile.cmake file.

Were there meant to be changes aside from adding the search hints in this PR?

This is a bad commit message. I previously had more export logic but realized it wasn't needed as it was already part of get_cufile.cmake

vyasr
vyasr reviewed Jun 14, 2022
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs reformatting, but otherwise LGTM.

@robertmaynard
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@b7c7adc). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 76ecd31 differs from pull request most recent head 78b20bc. Consider uploading reports for the commit 78b20bc to get more accurate results

@@               Coverage Diff               @@
##             branch-22.08   #11101   +/-   ##
===============================================
  Coverage                ?   86.34%           
===============================================
  Files                   ?      144           
  Lines                   ?    22738           
  Branches                ?        0           
===============================================
  Hits                    ?    19632           
  Misses                  ?     3106           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7c7adc...78b20bc. Read the comment docs.

@madsbk
Copy link
Member

madsbk commented Jun 16, 2022

rerun tests

@robertmaynard robertmaynard requested a review from vyasr June 16, 2022 16:25
@vyasr
Copy link
Contributor

vyasr commented Jun 16, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ac2d9a6 into rapidsai:branch-22.08 Jun 16, 2022
@robertmaynard robertmaynard deleted the cudfile_search_cuda_location branch June 17, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@harrism harrism harrism approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robertmaynard @vyasr @madsbk @harrism