Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Doxygen warnings in multiple headers files #11003

Merged
merged 24 commits into from
Jun 6, 2022
Merged
Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
c97c449
add missing doc in fixed_point.hpp
karthikeyann May 22, 2022
7089e34
using single docstring style
karthikeyann May 24, 2022
9151ee1
add missing docs in cudf_test/
karthikeyann May 27, 2022
529dc7b
add missing docs in parquet.hpp
karthikeyann May 27, 2022
284aea0
add misisng docs in nvtext/
karthikeyann May 27, 2022
46435c8
add missing docs in cudf_kafka/
karthikeyann May 27, 2022
ce2681c
add missing docs in cudf/ipc.hpp
karthikeyann May 27, 2022
2bb383b
Apply suggestions from code review
karthikeyann May 28, 2022
5779b9e
style fix copyright, add missing #pragma once
karthikeyann May 28, 2022
24c9c55
Merge branches 'doc-fix_warnings11' and 'doc-fix_warnings17' of githu…
karthikeyann Jun 1, 2022
2ce72b0
Merge branch 'branch-22.08' of https://github.com/rapidsai/cudf into …
karthikeyann Jun 1, 2022
c022dbf
exclude cudf_test/ and include column_wrapper and utilties
karthikeyann Jun 1, 2022
612be02
Apply suggestions from code review
karthikeyann Jun 1, 2022
dcda984
Apply suggestions from code review
karthikeyann Jun 1, 2022
6bb23cc
newline after \brief
karthikeyann Jun 1, 2022
8b1486a
Merge branch 'doc-fix_warnings17' of github.com:karthikeyann/cudf int…
karthikeyann Jun 1, 2022
d7a46c3
Apply suggestions from code review
karthikeyann Jun 1, 2022
0c4a1e2
adds blankline after \brief
karthikeyann Jun 1, 2022
06fb93f
add missed blankline after \brief
karthikeyann Jun 1, 2022
e114492
removing code ::testing::Types after excluding cudf_gtest.hpp
karthikeyann Jun 3, 2022
0a3098e
Apply suggestions from code review
karthikeyann Jun 3, 2022
e103bb6
Update cpp/include/cudf/io/parquet.hpp
karthikeyann Jun 5, 2022
4b29c2b
style fix
karthikeyann Jun 5, 2022
4fb276b
Merge branch 'branch-22.08' of https://github.com/rapidsai/cudf into …
karthikeyann Jun 5, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cpp/doxygen/Doxyfile
Original file line number Diff line number Diff line change
Expand Up @@ -818,6 +818,12 @@ INPUT = main_page.md \
regex.md \
unicode.md \
../include \
../include/cudf_test/column_wrapper.hpp \
../include/cudf_test/column_utilities.hpp \
../include/cudf_test/iterator_utilities.hpp \
../include/cudf_test/table_utilities.hpp \
../include/cudf_test/type_lists.hpp \
../include/cudf_test/type_list_utilities.hpp \
../libcudf_kafka/include

# This tag can be used to specify the character encoding of the source files
Expand Down Expand Up @@ -881,7 +887,7 @@ EXCLUDE_SYMLINKS = NO
# Note that the wildcards are matched against the file with absolute path, so to
# exclude all test directories for example use the pattern */test/*

EXCLUDE_PATTERNS = */nvtx/* */detail/*
EXCLUDE_PATTERNS = */nvtx/* */detail/* */cudf_test/*

# The EXCLUDE_SYMBOLS tag can be used to specify one or more symbol names
# (namespaces, classes, functions, etc.) that should be excluded from the
Expand Down
4 changes: 4 additions & 0 deletions cpp/include/cudf/column/column_device_view.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -1155,6 +1155,7 @@ struct value_accessor {

/**
* @brief constructor
*
* @param[in] _col column device view of cudf column
*/
value_accessor(column_device_view const& _col) : col{_col}
Expand Down Expand Up @@ -1244,6 +1245,7 @@ struct pair_accessor {

/**
* @brief constructor
*
* @param[in] _col column device view of cudf column
*/
pair_accessor(column_device_view const& _col) : col{_col}
Expand Down Expand Up @@ -1284,6 +1286,7 @@ struct pair_rep_accessor {

/**
* @brief constructor
*
* @param[in] _col column device view of cudf column
*/
pair_rep_accessor(column_device_view const& _col) : col{_col}
Expand Down Expand Up @@ -1317,6 +1320,7 @@ struct mutable_value_accessor {

/**
* @brief constructor
*
* @param[in] _col mutable column device view of cudf column
*/
mutable_value_accessor(mutable_column_device_view& _col) : col{_col}
Expand Down
2 changes: 2 additions & 0 deletions cpp/include/cudf/copying.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ std::unique_ptr<table> gather(

/**
* @brief Reverses the rows within a table.
*
* Creates a new table that is the reverse of @p source_table.
* Example:
* ```
Expand All @@ -103,6 +104,7 @@ std::unique_ptr<table> reverse(

/**
* @brief Reverses the elements of a column
*
* Creates a new column that is the reverse of @p source_column.
* Example:
* ```
Expand Down
21 changes: 19 additions & 2 deletions cpp/include/cudf/io/parquet.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -528,15 +528,20 @@ class parquet_writer_options {
/**
* @brief Returns the maximum uncompressed page size, in bytes. If set larger than the row group
* size, then this will return the row group size.
karthikeyann marked this conversation as resolved.
Show resolved Hide resolved
*
* @return Maximum uncompressed page size, in bytes
*/
auto get_max_page_size_bytes() const
{
return std::min(_max_page_size_bytes, get_row_group_size_bytes());
}

/**
* @brief Returns maximum page size, in rows. If set larger than the row group size, then this
* will return the row group size.
* @brief Returns maximum page size, in rows.
*
* If set larger than the row group size, then this will return the row group size.
*
* @return Maximum page size, in rows
*/
auto get_max_page_size_rows() const
{
Expand Down Expand Up @@ -638,6 +643,8 @@ class parquet_writer_options {

/**
* @brief Sets the maximum uncompressed page size, in bytes.
*
* @param size_bytes Maximum uncompressed page size, in bytes to set
karthikeyann marked this conversation as resolved.
Show resolved Hide resolved
*/
void set_max_page_size_bytes(size_t size_bytes)
{
Expand All @@ -647,6 +654,8 @@ class parquet_writer_options {

/**
* @brief Sets the maximum page size, in rows.
*
* @param size_rows Maximum page size, in rows to set
*/
void set_max_page_size_rows(size_type size_rows)
{
Expand Down Expand Up @@ -981,6 +990,8 @@ class chunked_parquet_writer_options {
/**
* @brief Returns maximum uncompressed page size, in bytes. If set larger than the row group size,
* then this will return the row group size.
*
* @return Maximum uncompressed page size, in bytes
*/
auto get_max_page_size_bytes() const
{
Expand All @@ -990,6 +1001,8 @@ class chunked_parquet_writer_options {
/**
* @brief Returns maximum page size, in rows. If set larger than the row group size, then this
* will return the row group size.
karthikeyann marked this conversation as resolved.
Show resolved Hide resolved
*
* @return Maximum page size, in rows
*/
auto get_max_page_size_rows() const
{
Expand Down Expand Up @@ -1065,6 +1078,8 @@ class chunked_parquet_writer_options {

/**
* @brief Sets the maximum uncompressed page size, in bytes.
*
* @param size_bytes Maximum uncompressed page size, in bytes to set
*/
void set_max_page_size_bytes(size_t size_bytes)
{
Expand All @@ -1074,6 +1089,8 @@ class chunked_parquet_writer_options {

/**
* @brief Sets the maximum page size, in rows.
*
* @param size_rows The maximum page size, in rows to set
*/
void set_max_page_size_rows(size_type size_rows)
{
Expand Down
3 changes: 3 additions & 0 deletions cpp/include/cudf/io/types.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,7 @@ class column_in_metadata {

/**
* @brief Gets the explicitly set nullability for this column.
*
* @throws If nullability is not explicitly defined for this column.
* Check using `is_nullability_defined()` first.
* @return Boolean indicating whether this column is nullable
Expand Down Expand Up @@ -549,6 +550,7 @@ class column_in_metadata {

/**
* @brief Get the decimal precision that was set for this column.
*
* @throws If decimal precision was not set for this column.
* Check using `is_decimal_precision_set()` first.
* @return The decimal precision that was set for this column
Expand All @@ -564,6 +566,7 @@ class column_in_metadata {

/**
* @brief Get the parquet field id that was set for this column.
*
* @throws If parquet field id was not set for this column.
* Check using `is_parquet_field_id_set()` first.
* @return The parquet field id that was set for this column
Expand Down
40 changes: 40 additions & 0 deletions cpp/include/cudf/ipc.hpp
Original file line number Diff line number Diff line change
@@ -1,15 +1,55 @@
/*
* Copyright (c) 2022, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

#pragma once

#include <arrow/api.h>
#include <arrow/gpu/cuda_api.h>
#include <arrow/io/memory.h>
#include <arrow/ipc/api.h>

/**
* @brief Reads Message objects from cuda buffer source
*
*/
class CudaMessageReader : arrow::ipc::MessageReader {
public:
/**
* @brief Construct a new Cuda Message Reader object from a cuda buffer stream
*
* @param stream The cuda buffer reader stream
* @param schema The schema of the stream
*/
CudaMessageReader(arrow::cuda::CudaBufferReader* stream, arrow::io::BufferReader* schema);

/**
* @brief Open stream from source.
*
* @param stream The cuda buffer reader stream
* @param schema The schema of the stream
* @return arrow::ipc::MessageReader object
*/
static std::unique_ptr<arrow::ipc::MessageReader> Open(arrow::cuda::CudaBufferReader* stream,
arrow::io::BufferReader* schema);

/**
* @brief Read next Message from the stream.
*
* @return arrow::ipc::Message object
*/
ttnghia marked this conversation as resolved.
Show resolved Hide resolved
arrow::Result<std::unique_ptr<arrow::ipc::Message>> ReadNextMessage() override;

private:
Expand Down
1 change: 1 addition & 0 deletions cpp/include/cudf/scalar/scalar_device_view.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ class scalar_device_view_base {

/**
* @brief Returns the value type
*
* @returns The value type
*/
[[nodiscard]] __host__ __device__ data_type type() const noexcept { return _type; }
Expand Down
13 changes: 12 additions & 1 deletion cpp/include/cudf_test/base_fixture.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ uint64_t random_generator_incrementing_seed();
template <typename T = cudf::size_type, typename Engine = std::default_random_engine>
class UniformRandomGenerator {
public:
using uniform_distribution = uniform_distribution_t<T>;
using uniform_distribution = uniform_distribution_t<T>; ///< The uniform distribution type for T.

UniformRandomGenerator() : rng{std::mt19937_64{detail::random_generator_incrementing_seed()}()} {}

Expand All @@ -144,6 +144,13 @@ class UniformRandomGenerator {
{
}

/**
* @brief Construct a new Uniform Random Generator to generate uniformly random booleans
*
PointKernel marked this conversation as resolved.
Show resolved Hide resolved
* @param lower ignored
* @param upper ignored
* @param seed seed to initialize generator with
*/
template <typename TL = T, std::enable_if_t<cudf::is_boolean<TL>()>* = nullptr>
UniformRandomGenerator(T lower,
T upper,
Expand Down Expand Up @@ -179,6 +186,10 @@ class UniformRandomGenerator {
return T{dist(rng)};
}

/**
* @brief Returns the next random number.
PointKernel marked this conversation as resolved.
Show resolved Hide resolved
* @return generated random number
*/
template <typename TL = T, std::enable_if_t<cudf::is_timestamp<TL>()>* = nullptr>
T generate()
{
Expand Down
33 changes: 30 additions & 3 deletions cpp/include/cudf_test/column_wrapper.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,14 @@ class column_wrapper {
*/
template <typename From, typename To>
struct fixed_width_type_converter {
// Are the types same - simply copy elements from [begin, end) to out
/**
* @brief No conversion necessary: Same type, simply copy element to output.
*
* @tparam FromT Source type
* @tparam ToT Target type
* @param element Source value
* @return The converted target value, same as source value
*/
template <typename FromT = From,
typename ToT = To,
std::enable_if_t<std::is_same_v<FromT, ToT>, void>* = nullptr>
Expand All @@ -103,7 +110,14 @@ struct fixed_width_type_converter {
return element;
}

// Are the types convertible or can target be constructed from source?
/**
* @brief Convert types if possible, otherwise construct target from source.
*
* @tparam FromT Source type
* @tparam ToT Target type
* @param element Source value
* @return The converted target value
*/
template <
typename FromT = From,
typename ToT = To,
Expand All @@ -115,7 +129,14 @@ struct fixed_width_type_converter {
return static_cast<ToT>(element);
}

// Convert integral values to timestamps
/**
* @brief Convert integral values to timestamps
*
* @tparam FromT Source type
* @tparam ToT Target type
* @param element Source value
* @return The converted target `timestamp` value
*/
template <
typename FromT = From,
typename ToT = To,
Expand Down Expand Up @@ -484,6 +505,11 @@ class fixed_width_column_wrapper : public detail::column_wrapper {
}
};

/**
* @brief A wrapper for a column of fixed-width elements.
*
* @tparam Rep The type of the column
*/
template <typename Rep>
class fixed_point_column_wrapper : public detail::column_wrapper {
public:
Expand Down Expand Up @@ -1445,6 +1471,7 @@ class lists_column_wrapper : public detail::column_wrapper {
* @brief Construct a list column containing a single empty, optionally null row.
*
* @param valid Whether or not the empty row is also null
* @return A list column containing a single empty row
*/
static lists_column_wrapper<T> make_one_empty_row_column(bool valid = true)
{
Expand Down
Loading