Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cuCollections for thrust upgrade #10983

Merged
merged 7 commits into from
Jun 7, 2022
Merged

Update cuCollections for thrust upgrade #10983

merged 7 commits into from
Jun 7, 2022

Conversation

PointKernel
Copy link
Member

@PointKernel PointKernel commented May 26, 2022 •
edited
Loading

Depends on NVIDIA/cuCollections#165 and NVIDIA/cuCollections#171

This is a preparation step to finally address #10841. It fetches the latest version of cuco that adds missing thrust headers and improves static_map::retrieve_all.

@PointKernel PointKernel added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 26, 2022
@PointKernel PointKernel self-assigned this May 26, 2022
@github-actions github-actions bot added the CMake CMake build issue label May 26, 2022
@PointKernel PointKernel mentioned this pull request May 26, 2022
Merged
@codecov
Copy link

codecov bot commented May 26, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@fe9a4f8). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08   #10983   +/-   ##
===============================================
  Coverage                ?   86.33%           
===============================================
  Files                   ?      144           
  Lines                   ?    22706           
  Branches                ?        0           
===============================================
  Hits                    ?    19604           
  Misses                  ?     3102           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe9a4f8...c6e69c0. Read the comment docs.

@PointKernel PointKernel mentioned this pull request May 27, 2022
Merged
@PointKernel PointKernel marked this pull request as ready for review June 6, 2022 20:10
@PointKernel PointKernel requested review from a team as code owners June 6, 2022 20:10
@PointKernel PointKernel requested review from bdice and nvdbaranec June 6, 2022 20:10
@PointKernel PointKernel added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jun 6, 2022
bdice
bdice approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vyasr
Copy link
Contributor

vyasr commented Jun 7, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 20b07bf into rapidsai:branch-22.08 Jun 7, 2022
@PointKernel PointKernel deleted the cuco-thrust-upgrade branch November 16, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@bdice bdice bdice approved these changes

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@PointKernel PointKernel

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PointKernel @vyasr @bdice